Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SendingCommand event #2793

Merged
merged 8 commits into from
Oct 28, 2024
Merged

Added SendingCommand event #2793

merged 8 commits into from
Oct 28, 2024

Conversation

angelseraphim
Copy link
Contributor

:3

@github-actions github-actions bot added regarding-events An issue or PR targeting the Exiled Events project regarding-transpiler An issue or PR that touches or is related to a patch labels Oct 28, 2024
xNexusACS
xNexusACS requested changes Oct 28, 2024
View reviewed changes
Copy link
Member

@xNexusACS xNexusACS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets improve a little bit some of the summaries

Exiled.Events/Patches/Events/Player/SendingCommand.cs Outdated Show resolved Hide resolved
Exiled.Events/EventArgs/Player/SendingCommandEventArgs.cs Outdated Show resolved Hide resolved
Exiled.Events/EventArgs/Player/SendingCommandEventArgs.cs Outdated Show resolved Hide resolved
@xNexusACS
Copy link
Member

one question I have, does either Query or Command becomes null when the command doesn't exists?

@angelseraphim
Copy link
Contributor Author

The patch works after the command. Because of this, it cannot be null

@xNexusACS
Copy link
Member

The patch works after the command. Because of this, it cannot be null

what I mean is, if the command doesn't exist in RemoteAdmin, does the ICommand inferface becomes null?

@angelseraphim
Copy link
Contributor Author

If there is no command, the event will not be called
CommandProcessor.RemoteAdminCommandHandler.TryGetCommand

@xNexusACS
Copy link
Member

If there is no command, the event will not be called CommandProcessor.RemoteAdminCommandHandler.TryGetCommand

oh, nice

@angelseraphim
Copy link
Contributor Author

:D

@xNexusACS xNexusACS mentioned this pull request Oct 28, 2024
Merged
5 tasks
@xNexusACS xNexusACS merged commit 7d99daf into Exiled-Team:master Oct 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xNexusACS xNexusACS xNexusACS approved these changes

Assignees

@angelseraphim angelseraphim

Labels
regarding-events An issue or PR targeting the Exiled Events project regarding-transpiler An issue or PR that touches or is related to a patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@angelseraphim @xNexusACS