Groups integrations updates for pandeia/pandexo v1.4

[bourque]

This PR updates the groups & integrations calculator with various updates needed for pandeia/pandexo version 1.4.

[pep8speaks]

Hello @bourque, Thank you for updating !

• In the file exoctk/exoctk_app/app_exoctk.py:

Line 193:21: W605 invalid escape sequence '('
Line 193:25: W605 invalid escape sequence ')'
Line 193:57: W605 invalid escape sequence '\c'
Line 193:74: W605 invalid escape sequence '\e'
Line 199:46: W605 invalid escape sequence '('
Line 199:48: W605 invalid escape sequence '\l'
Line 199:56: W605 invalid escape sequence '\m'
Line 199:66: W605 invalid escape sequence '\h'
Line 199:79: W605 invalid escape sequence '\m'
Line 199:85: W605 invalid escape sequence ')'
Line 200:46: W605 invalid escape sequence '('
Line 200:48: W605 invalid escape sequence '\l'
Line 200:56: W605 invalid escape sequence '\m'
Line 200:66: W605 invalid escape sequence '\h'
Line 200:79: W605 invalid escape sequence '\m'
Line 200:85: W605 invalid escape sequence ')'
Line 201:46: W605 invalid escape sequence '('
Line 201:48: W605 invalid escape sequence '\l'
Line 201:56: W605 invalid escape sequence '\m'
Line 201:66: W605 invalid escape sequence '\h'
Line 201:79: W605 invalid escape sequence '\m'
Line 201:85: W605 invalid escape sequence ')'
Line 207:58: W605 invalid escape sequence '('
Line 207:62: W605 invalid escape sequence '\m'
Line 207:69: W605 invalid escape sequence '\m'
Line 207:75: W605 invalid escape sequence ')'
Line 517:42: E261 at least two spaces before inline comment
Line 523:1: E302 expected 2 blank lines, found 1
Line 528:52: E231 missing whitespace after ','
Line 533:69: E261 at least two spaces before inline comment
Line 533:69: E262 inline comment should start with '# '
Line 534:5: E265 block comment should start with '# '

• In the file exoctk/tests/test_groups_integrations.py:

Line 49:1: E124 closing bracket does not match visual indentation
Line 58:1: E124 closing bracket does not match visual indentation

Comment last updated at 2020-10-13 19:51:06 UTC

[bourque]

@nespinoza Could you review this? I think this is good to go.

I tested the groups and integrations calculator locally, through the web app, and everything seems to be working fine. I'm not sure if the results that are being returned are reasonable, however. Please let me know if you have any suggestions on how to test that out and make sure that they are reasonable.

This PR does add unit tests that make sure the contents and the structure of the groups_integrations.json file are what is expected. There is also one test in there that ensures that the output of the perform_calculation() function in groups_integrations.py is also what is expected. If you can think of any other tests to add, just let me know!

Lastly, it seems that before, the web app was using the groups_integrations_input_data.json file located within the data/ directory of the package, and not the groups_integrations.json file within the $EXOCTK_DATA package -- not sure why that is, but I switched it so that it now uses a file named groups_integrations.json within the data/ directory.

[nespinoza]

Hey @bourque --- this is fantastic, thanks for all the work on this! We need to validate this against the JWST ETC I believe before merging for both bright-end targets (e.g., WASP-18) and faint-end targets (e.g., TRAPPIST-1). If you can do this, that would be great, but if you are not familiar with the JWST ETC I can do this tomorrow.

[bourque]

@nespinoza Perhaps we could do a Slack call tomorrow and test it together? That way I could learn how to better navigate the JWST ETC and hopefully be able to do this myself in the future.

[nespinoza]

That sounds like a plan @bourque! Let's decide for a time internally :-).

[bourque]

Moving this Issue for the release 1.2 project, as there are some result descrepencies to figure out first.

[hover2pi]

@nespinoza @bourque Does this need a validation test before merging to make sure the results are what we expect? Is there a way to do it without involving the ETC so we can have CI test it with each build?