Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NRS Visibility Plot #618

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

mfixstsci
Copy link
Contributor

NRS does not have a dictionary key in field_simulator.APERTURES. This checks the value being passed from the form and if it is NRS, just make the instrument variable the string passed from the form. Data from the dictionary is only needed for calculating contamination.

@mfixstsci mfixstsci requested a review from hover2pi September 10, 2024 17:45
@pep8speaks
Copy link

Hello @mfixstsci, Thank you for submitting the Pull Request !

Line 390:1: W293 blank line contains whitespace
Line 755:21: W605 invalid escape sequence '('
Line 755:25: W605 invalid escape sequence ')'
Line 755:57: W605 invalid escape sequence '\c'
Line 755:74: W605 invalid escape sequence '\e'
Line 761:46: W605 invalid escape sequence '('
Line 761:48: W605 invalid escape sequence '\l'
Line 761:56: W605 invalid escape sequence '\m'
Line 761:66: W605 invalid escape sequence '\h'
Line 761:79: W605 invalid escape sequence '\m'
Line 761:85: W605 invalid escape sequence ')'
Line 762:46: W605 invalid escape sequence '('
Line 762:48: W605 invalid escape sequence '\l'
Line 762:56: W605 invalid escape sequence '\m'
Line 762:66: W605 invalid escape sequence '\h'
Line 762:79: W605 invalid escape sequence '\m'
Line 762:85: W605 invalid escape sequence ')'
Line 763:46: W605 invalid escape sequence '('
Line 763:48: W605 invalid escape sequence '\l'
Line 763:56: W605 invalid escape sequence '\m'
Line 763:66: W605 invalid escape sequence '\h'
Line 763:79: W605 invalid escape sequence '\m'
Line 763:85: W605 invalid escape sequence ')'
Line 769:58: W605 invalid escape sequence '('
Line 769:62: W605 invalid escape sequence '\m'
Line 769:69: W605 invalid escape sequence '\m'
Line 769:75: W605 invalid escape sequence ')'
Line 794:25: W605 invalid escape sequence '('
Line 794:29: W605 invalid escape sequence ')'
Line 794:61: W605 invalid escape sequence '\c'
Line 794:78: W605 invalid escape sequence '\e'
Line 800:50: W605 invalid escape sequence '('
Line 800:52: W605 invalid escape sequence '\l'
Line 800:60: W605 invalid escape sequence '\m'
Line 800:70: W605 invalid escape sequence '\h'
Line 800:83: W605 invalid escape sequence '\m'
Line 800:89: W605 invalid escape sequence ')'
Line 801:50: W605 invalid escape sequence '('
Line 801:52: W605 invalid escape sequence '\l'
Line 801:60: W605 invalid escape sequence '\m'
Line 801:70: W605 invalid escape sequence '\h'
Line 801:83: W605 invalid escape sequence '\m'
Line 801:89: W605 invalid escape sequence ')'
Line 802:50: W605 invalid escape sequence '('
Line 802:52: W605 invalid escape sequence '\l'
Line 802:60: W605 invalid escape sequence '\m'
Line 802:70: W605 invalid escape sequence '\h'
Line 802:83: W605 invalid escape sequence '\m'
Line 802:89: W605 invalid escape sequence ')'
Line 808:62: W605 invalid escape sequence '('
Line 808:66: W605 invalid escape sequence '\m'
Line 808:73: W605 invalid escape sequence '\m'
Line 808:79: W605 invalid escape sequence ')'

If you have not done so, please consult PEP8 and PEP257

@mfixstsci mfixstsci requested a review from nespinoza September 10, 2024 17:45
@mfixstsci mfixstsci self-assigned this Sep 10, 2024
Copy link
Member

@hover2pi hover2pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it.

@hover2pi hover2pi merged commit 01e6e13 into ExoCTK:develop Sep 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants