-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language blocks as table/dl via AsciiDoc, removing problematic flags #25
base: master
Are you sure you want to change the base?
Conversation
Hi @toastal and thanks for the proposal! I agree with you about the flags and I like the new rendering. I am not familiar with this so could you please explain:
This overall feels less standard to me, but I'm happy to be proven wrong here. |
What does AsciiDoc bring? In this case, more semantic elements for this markup. The English idiom is "when you have a hammer, everything looks like a nail" and that's how this seemed the Alternatively, a |
Hello, I agree with @toastal about the general advantage of asciiDoc. but in our case it will make to type of markup language to maintain. The blog use markdown (with Hugo). Btw, I read that Hugo can use asciiDoc as source format but changing ALL the website markup will be a huge work and we did not have time for that. |
Well then I wouldn't recommend changing everything. Feel free to close this bug however if you have a flag-less solution of your own. |
Can we reach a compromise and remove the flags without changing the doc format? |
Sure. I would suggest a table, but this is specific to GitHub's Markdown dialect and not the larger Markdown spec. |
Sound a good compromise for me. |
Flags are not languages. To remove this problematic issue, I moved the list to a horizontal definition list (which is rendered as a table). I tried using some other formatting options but most were not compatible with GitHub's default styling. I think this provides the best alternative while still maintaining IDs. Unfortunately
lang
attributes are stripped or I'd wrap the whole block to help with the accessibility. To view a preview of this commit rendered in GitHub: https://github.com/toastal/anim-com/blob/lang-blocks%2Bno-flags/README.adoc.Additionally, I added proper curly punctuation to English and German.