fix(keychain)!: only export secret if "exportPrivate" flag is set (#139)

ExodusMovement · Sep 13, 2024 · 7a01522 · 7a01522
1 parent 6762be9
commit 7a01522
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/features/keychain/module/__tests__/sodium.test.js b/features/keychain/module/__tests__/sodium.test.js
@@ -40,10 +40,12 @@ describe('libsodium', () => {
     const {
       sign: { privateKey: signPrivateKey },
       box: { privateKey: boxPrivateKey },
+      secret,
     } = await keychain.sodium.getSodiumKeysFromSeed({ seedId, keyId: ALICE_KEY })
 
     expect(signPrivateKey).toBeNull()
     expect(boxPrivateKey).toBeNull()
+    expect(secret).toBeNull()
   })
 
   it('should allow exporting private keys', async () => {
@@ -52,6 +54,7 @@ describe('libsodium', () => {
     const {
       sign: { privateKey: signPrivateKey },
       box: { privateKey: boxPrivateKey },
+      secret,
     } = await keychain.sodium.getSodiumKeysFromSeed({
       seedId,
       keyId: ALICE_KEY,
@@ -60,6 +63,7 @@ describe('libsodium', () => {
 
     expect(signPrivateKey).toBeDefined()
     expect(boxPrivateKey).toBeDefined()
+    expect(secret).toBeDefined()
   })
 
   it('should have sign keys compatibility with SLIP10 (using sodium instance)', async () => {

diff --git a/features/keychain/module/crypto/sodium.js b/features/keychain/module/crypto/sodium.js
@@ -30,7 +30,7 @@ export const create = ({ getPrivateHDKey }) => {
       return {
         box: cloneKeypair({ keys: box, exportPrivate }),
         sign: cloneKeypair({ keys: sign, exportPrivate }),
-        secret: cloneBuffer(secret),
+        secret: exportPrivate ? cloneBuffer(secret) : null,
       }
     },
     sign: async ({ seedId, keyId, data }) => {