fix: connect wallet #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/utils/src/network.ts
Outdated
| @@ -26,6 +26,7 @@ export function getBrowserOnlineStatus() { | |||
| export async function getReactNativeOnlineStatus(): Promise<boolean> { | |||
| // global.NetInfo is set in react-native-compat | |||
| if (isReactNative() && typeof global !== "undefined" && (global as any)?.NetInfo) { | |||
| return true; // TODO: discuss on adding react-native-community/netinfo | |||
There was a problem hiding this comment.
@matias-la react-native-community/netinfo is needed for this. what'd be best action here ?
There was a problem hiding this comment.
repace with @exodus/netinfo ?
There was a problem hiding this comment.
@ezenwankwogabriel yeah, we have @exodus/[email protected] audited - you can give it a try
matias-la
approved these changes
Jan 26, 2024
This reverts commit 137ad4b.
- @exodus/netinfo uses isconnected.fetch()
ezenwankwogabriel
merged commit 4fab931
into
gabriel/upgrade-fork-2.11.0
4 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes error on connecting wallet from the package bumps
Please include a brief summary of the change.
Type of change
How has this been tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your configuration.
Fixes/Resolves (Optional)
Please list any issues that are fixed by this PR in the format
#<issue number>. If it fixes multiple issues, please put each issue in a separate line. If this Pull Request does not fix any issues, please delete this section.Examples/Screenshots (Optional)
Please attach a screenshot or screen recording of features/fixes you've implemented to verify your changes. Please also note any relevant details for your configuration. If your changes do not affect the UI, please delete this section.
Use this table template to show examples of your changes:
Checklist
Additional Information (Optional)
Please include any additional information that may be useful for the reviewer.