add finish to detectormanager span (#765)

ExpediaGroup · Jul 6, 2020 · b19b2e4 · b19b2e4
1 parent 21a7742
commit b19b2e4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/kafka/src/main/java/com/expedia/adaptivealerting/kafka/KafkaDetectorManager.java b/kafka/src/main/java/com/expedia/adaptivealerting/kafka/KafkaDetectorManager.java
@@ -270,12 +270,14 @@ private void detectorManagerExtractAndInjectSpan(ConsumerRecord<String, MappedMe
         }
         // TODO
         // If there is a way to add custom tags without creating span that should be used
+        // Span is being created only to add tags to the complete trace managed by library.
         else {
             detectorManagerSpan = GlobalTracer.get().buildSpan("detector-manager").
                     withTag("metric", metricRecord.key()).start();
         }
         detectorManagerSpan.setTag("detectorUUID", anomalyRecord.key());
         TracingKafkaUtils.inject(detectorManagerSpan.context(), anomalyRecord.headers(), GlobalTracer.get());
+        detectorManagerSpan.finish();
     }
 
 }
diff --git a/kafka/src/main/resources/config/base.conf b/kafka/src/main/resources/config/base.conf
@@ -34,6 +34,8 @@ ad-manager {
   throttle-gate-likelihood = 0.05
   graphite-data-retrieval-key = "data-retrieval-key"
   tracing {
+  # tracingStatus is a required parameter. It can be set to disabled/other value
+  # than enabled to not include tracing for the module.
       tracingStatus = "enabled"
       apiKey = "acdefghijklmnopqrstuvwxyz"
       clientId = "ad-manager"

diff --git a/kafka/src/test/resources/detector-manager.conf b/kafka/src/test/resources/detector-manager.conf
@@ -22,6 +22,8 @@ graphite-data-retrieval-key = "data-retrieval-key"
 throttle-gate-likelihood = 0.05
 
 tracing {
+  # tracingStatus is a required parameter. It can be set to disabled/other value
+  # than enabled to not include tracing.
       tracingStatus = "enabled"
       apiKey = "acdefghijklmnopqrstuvwxyz"
       clientId = "ad-manager"