Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new variable apiary_domain_private_zone to support zone pri… #261

Merged
merged 4 commits into from
May 31, 2024
Merged

feat: add new variable apiary_domain_private_zone to support zone pri… #261

merged 4 commits into from
May 31, 2024

Conversation

githubjianli
Copy link
Collaborator

@githubjianli githubjianli commented May 31, 2024 •
edited
Loading

…vate or public

📝 Description

  • Fixed route53 HMS alias
  • Added private_zone option
  • Removed vpc_id from zone filter

🔗 Related Issues

@githubjianli githubjianli requested a review from a team as a code owner May 31, 2024 00:34
@githubjianli githubjianli merged commit 5a30c71 into master May 31, 2024
2 checks passed
@githubjianli githubjianli deleted the feature/add_apiary_domain_zone branch May 31, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patduin patduin patduin approved these changes

@abhimanyugupta07 abhimanyugupta07 abhimanyugupta07 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@githubjianli @abhimanyugupta07 @patduin @JianLi-Expedia