fix: Added apiary_extra_tags_s3 variable to the s3 checkpoint bucket to add extra tags
#284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to add extra tags
JayGreeeen
reviewed
Oct 24, 2024
| @@ -42,6 +42,7 @@ locals { | |||
| enable_apiary_s3_log_management = var.apiary_log_bucket == "" ? true : false | |||
| enable_apiary_s3_log_hive = var.apiary_log_bucket == "" && var.enable_apiary_s3_log_hive ? true : false | |||
| apiary_s3_logs_bucket = local.enable_apiary_s3_log_management ? "${local.apiary_bucket_prefix}-s3-logs" : "" | |||
| apiary_s3_logs_checkpoint_bucket= "${local.apiary_bucket_prefix}-s3-logs-checkpoint" | |||
There was a problem hiding this comment.
Add a space before the = and then align the rest of the assignments too please
Suggested change
| apiary_s3_logs_checkpoint_bucket= "${local.apiary_bucket_prefix}-s3-logs-checkpoint" | |
| apiary_s3_logs_checkpoint_bucket = "${local.apiary_bucket_prefix}-s3-logs-checkpoint" |
JayGreeeen
reviewed
Oct 24, 2024
| @@ -138,6 +138,47 @@ EOF | |||
| } | |||
| } | |||
|
|
|||
| resource "aws_s3_bucket" "s3_logs_checkpoint" { | |||
|
After a talk with Jian Li, we figured out this new bucket was not necessary and that we can reuse a folder within system bucket, as we have limited buckets, so I will push a pr for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Related Issues