Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #171

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README.md #171

wants to merge 1 commit into from

Conversation

etapiaromero
Copy link

Fixes #

patduin
patduin reviewed Nov 13, 2023
View reviewed changes
README.md
@@ -101,7 +101,7 @@ Beekeeper only actions on events which are marked with specific parameters. Thes
| `beekeeper.unreferenced.data.retention.period=X` | No | e.g. `P7D` or `PT3H` (based on [ISO 8601 format](https://en.wikipedia.org/wiki/ISO_8601)) | Set this parameter to control the delay between schedule and deletion by Beekeeper. If this is either not set, or configured incorrectly, the default will be used. Default is 3 days. |
| `beekeeper.hive.event.whitelist=X` | No | Comma separated list of event types to whitelist for orphaned data. Valid event values are: `alter_partition`, `alter_table`, `drop_table`, `drop_partition`. | Beekeeper will only process whitelisted events. Default value: `alter_partition`, `alter_table`. |
| `beekeeper.remove.expired.data=true` | Yes | `true` or `false` | Set this parameter to enable TTL on your table. |
| `beekeeper.expired.data.retention.period=X` | No | e.g. `P7D` or `PT3H` (based on [ISO 8601 format](https://en.wikipedia.org/wiki/ISO_8601)) | Set this parameter to control the TTL duration for your table. If this is either not set, or configured incorrectly, the default value of `P30D` (30 days) will be used. |
| `beekeeper.expired.data.retention.period=X` | No | e.g. `P7D` or `PT3H` (based on [ISO 8601 format](https://en.wikipedia.org/wiki/ISO_8601)) | Set this parameter to control the TTL duration for your table. If this is either not set, or configured incorrectly, the default value of `P30D` (30 days) will be used. The TTL value excludes current date, e.g. if value is `P2D` and today is Oct 20th, then data from Oct 18th will be kept.|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that true?
https://github.com/ExpediaGroup/beekeeper/blob/main/beekeeper-core/src/main/java/com/expediagroup/beekeeper/core/model/HousekeepingPath.java#L118
Doesn't that code imply that we just take the timestamp and add the period.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patduin patduin patduin left review comments

@alangr28 alangr28 alangr28 approved these changes

@RickArt RickArt RickArt approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@etapiaromero @patduin @RickArt @alangr28