fix:API-paging #172
Merged
fix:API-paging #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating converter classes and adding tests for paging
andreeapad
reviewed
Nov 2, 2023
.../src/test/java/com/expediagroup/beekeeper/api/response/HousekeepingMetadataResponseTest.java
Show resolved
Hide resolved
andreeapad
reviewed
Nov 2, 2023
...ts/src/test/java/com/expediagroup/beekeeper/integration/api/BeekeeperApiIntegrationTest.java
Outdated
Show resolved
Hide resolved
andreeapad
reviewed
Nov 2, 2023
...ts/src/test/java/com/expediagroup/beekeeper/integration/api/BeekeeperApiIntegrationTest.java
Outdated
Show resolved
Hide resolved
andreeapad
reviewed
Nov 2, 2023
...ts/src/test/java/com/expediagroup/beekeeper/integration/api/BeekeeperApiIntegrationTest.java
Outdated
Show resolved
Hide resolved
added 2 commits
November 3, 2023 12:49
Added test to HousekeepingMetadataResponseTest to ensure paging works with multiple pages and elements add another test where these values are not the default ones (more than 1 page and total num of elements is higher than the page size)
|
add a changelog entry please |
andreeapad
reviewed
Nov 7, 2023
Co-authored-by: Andreea Paduraru <[email protected]>
andreeapad
reviewed
Nov 9, 2023
...per-api/src/test/java/com/expediagroup/beekeeper/api/response/PathResponseConverterTest.java
Outdated
Show resolved
Hide resolved
…ponse/PathResponseConverterTest.java
andreeapad
reviewed
Nov 9, 2023
...ts/src/test/java/com/expediagroup/beekeeper/integration/api/BeekeeperApiIntegrationTest.java
Outdated
Show resolved
Hide resolved
andreeapad
reviewed
Nov 9, 2023
...ts/src/test/java/com/expediagroup/beekeeper/integration/api/BeekeeperApiIntegrationTest.java
Outdated
Show resolved
Hide resolved
...per-api/src/main/java/com/expediagroup/beekeeper/api/response/MetadataResponseConverter.java
Outdated
Show resolved
Hide resolved
beekeeper-api/src/main/java/com/expediagroup/beekeeper/api/response/PathResponseConverter.java
Outdated
Show resolved
Hide resolved
…ponse/PathResponseConverter.java Co-authored-by: Abhimanyu Gupta <[email protected]>
Extracting sections as code constants
Remove comment from Integration test
Remove comment from Integration test
andreeapad
reviewed
Nov 10, 2023
...ts/src/test/java/com/expediagroup/beekeeper/integration/api/BeekeeperApiIntegrationTest.java
Outdated
Show resolved
Hide resolved
andreeapad
reviewed
Nov 10, 2023
...ts/src/test/java/com/expediagroup/beekeeper/integration/api/BeekeeperApiIntegrationTest.java
Outdated
Show resolved
Hide resolved
…keeper/integration/api/BeekeeperApiIntegrationTest.java Co-authored-by: Andreea Paduraru <[email protected]>
andreeapad
approved these changes
Nov 10, 2023
abhimanyugupta07
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating converter classes and adding tests for paging