Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask PCI Security-Sensitive Information #76

Merged
merged 10 commits into from
Oct 8, 2023

Conversation

osama-salman99
Copy link
Contributor

  • Code is up-to-date with the main branch.
  • You've successfully built and run the tests locally.
  • There are new or updated unit tests validating the change.

📝 Description

  • Mask PCI security-sensitive information

🔗 Related Issues

N/A

Mask PCI security-sensitive information
Mask PCI security-sensitive information
Mask PCI security-sensitive information
Mask PCI security-sensitive information
Mask PCI security-sensitive information
Mask PCI security-sensitive information
Mask PCI security-sensitive information
@osama-salman99 osama-salman99 added the Ready for Review The pull request is ready for review label Oct 8, 2023
Mask PCI security-sensitive information
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f0a3567) 100.00% compared to head (4f4661d) 100.00%.
Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #76   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          212       219    +7     
  Branches        12        14    +2     
=========================================
+ Hits           212       219    +7     
Files Coverage Δ
core/src/constant/LogMaskingRegex.ts 100.00% <100.00%> (ø)
core/src/logging/LogMasker.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Mask PCI security-sensitive information
Mask PCI security-sensitive information
@osama-salman99 osama-salman99 merged commit 1317101 into main Oct 8, 2023
@osama-salman99 osama-salman99 deleted the osama-salman99/pci-logs-hotfix branch October 8, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Review The pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants