-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD] Add beta and initial WIP for detecting natural search #56544
Conversation
src/styles/utils/sizing.ts
Outdated
@@ -25,8 +25,8 @@ export default { | |||
width: '15%', | |||
}, | |||
|
|||
w20: { | |||
width: '20%', | |||
w20px: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might be able to just reuse our iconSizeNormal var?
Line 79 in 68d16de
iconSizeNormal: 20, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
…/App into tgolen-natural-language-search
…/App into tgolen-natural-language-search
…_response Showing AI items on saved menu and recent searches
…/App into tgolen-natural-language-search
…_mag_animation Updated logic to check the amount of words
🚧 @shawnborton has triggered a test build. You can view the workflow run here. |
@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
Fun times on Friday! What's the plan with this frontend PR? |
It probably makes sense to revert everything and then run this through WN if we want it to become an official project? |
Looks like we never merged this frontend work, and since we're reverting the backend work we should close this out. |
Explanation of Change
This PR adds functionality to perform a natural language search on the search page
Fixed Issues
None: AI Hackathon 2025
Tests
Offline tests
None. This requires online functionality
QA Steps
None because this feature is behind a beta
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop