-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump react-native-keyboard-controller to 1.16.7 #57580
base: main
Are you sure you want to change the base?
Conversation
|
@QichenZhu @kirillzyusko @chrispader this seems to be blocking #57128. What are the next steps here? |
This comment was marked as resolved.
This comment was marked as resolved.
@mountiny @QichenZhu no it's not blocking, it was just my mistake bumping the lib in the other PR. We don't need the updated version |
Sorry for the confusion @QichenZhu |
|
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Explanation of Change
Fixed Issues
$ #56156
PROPOSAL: #56156 (comment)
Tests
This test applies to mobile devices only.
Precondition: Log in to an account with 8 or more expenses. Create some if necessary.
Offline tests
N/A. This test requires an active internet connection.
QA Steps
This test applies to mobile devices only.
Precondition: Log in to an account with 8 or more expenses. Create some if necessary.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionN/A: This test requires an active internet connection.
QA steps
sectionhttps://expensify.slack.com/archives/C01GTK53T8Q/p1741041211288999
https://expensify.slack.com/archives/C049HHMV9SM/p1741433172815909
toggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.Not added as 1: This repo doesn't currently support automation tests on Android. 2. Most of the changes are covered by the upstream library's e2e tests.
main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android-native.mp4
Android: mWeb Chrome
android-web.mp4
iOS: Native
ios-native.mp4
iOS: mWeb Safari
ios-web.mp4
MacOS: Chrome / Safari
mac-web.mov
MacOS: Desktop
mac-desktop.mp4