Skip to content

Avoid duplicated copy #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Avoid duplicated copy #691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/OnyxCache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,8 +471,7 @@ class OnyxCache {
return undefined;
}

// Return a shallow copy to ensure React detects changes when items are added/removed
return {...cachedCollection};
return cachedCollection;
}
}

Expand Down
3 changes: 2 additions & 1 deletion lib/OnyxUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,8 @@ function tryGetCachedValue<TKey extends OnyxKey>(key: TKey): OnyxValue<OnyxKey>
if (isCollectionKey(key)) {
const collectionData = cache.getCollectionData(key);
if (collectionData !== undefined) {
val = collectionData;
// Return a shallow copy to ensure React detects changes when items are added/removed
val = {...collectionData};
} else {
// If we haven't loaded all keys yet, we can't determine if the collection exists
if (cache.getAllKeys().size === 0) {
Expand Down