-
Notifications
You must be signed in to change notification settings - Fork 83
chore: Update NitroSQLite to use new DatabaseQueue implementation
#700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update NitroSQLite to use new DatabaseQueue implementation
#700
Conversation
DatabaseQueue implementationDatabaseQueue implementation
|
Putting this on hold so we dont accidentally merge it before we get through with next onyx update in App that is handled by @VickyStash Expensify/App#74489 |
DatabaseQueue implementationDatabaseQueue implementation
DatabaseQueue implementationDatabaseQueue implementation
mountiny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HOLDING for Expensify/App#74489 deployment to prod
DatabaseQueue implementationDatabaseQueue implementation
DatabaseQueue implementationDatabaseQueue implementation
mountiny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous bump is now in production so we can move this one ahead
@mountiny @shubham1206agra
Details
This PR updates NitroSQLite to version
9.2.0which includes a newDatabaseQueueimplementation, to avoid conflicts with overlapping/simultaneous transactions and batch operations. This also requires Nitro Modules to be updated to version0.27.2.The
DatabaseQueuewas introduced into in NitroSQLite in margelo/react-native-nitro-sqlite#227Related Issues
Expensify/App#73793 (comment)
Automated Tests
None.
Manual Tests
[SqlExecutionError] cannot rollback - no transaction is active[SqlExecutionError] cannot start a transaction within a transactionAuthor Checklist
### Related Issuessection aboveTestssectiontoggleReportand notonIconClick)myBool && <MyComponent />.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Avataris modified, I verified thatAvataris working as expected in all cases)mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop