forked from necolas/react-native-web
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync fork with upstream #19
Open
janicduplessis
wants to merge
14
commits into
Expensify:master
Choose a base branch
from
janicduplessis:@janic/expensify-update-fork
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sync fork with upstream #19
janicduplessis
wants to merge
14
commits into
Expensify:master
from
janicduplessis:@janic/expensify-update-fork
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ignore CSS transforms in measurement. * Cancel measurement if elements are unmounted. Close necolas#2501 Fix necolas#1254
This API will be removed in a future version.
Linking.removeEventListener() was deprecated in [email protected] Fix necolas#2507
Migrate to 'addEventListener' helper. Fix necolas#2459
Thanks for opening this @janicduplessis. I'm going to use this issue to list out the custom changes in our react-native-web fork to see which are outstanding, which have been merged upstream, and which we're even using. |
Everything merged cleanly except for VirtualizedList, which I made sure to apply 05410db which I think was the only change that was not upstreamed. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This include a lot of VirtualizedList improvements and fixes. Notably this fixes an issue with inverted FlatList that forced us to use batchSize=1.
Upstream now also includes the changes to add onStartReached.