Added one piano keyboard scale #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iano to Z...,. Added more keyboard sounds. Moved sounds to a keyboard-olds folder. Missing b note and #'s.
guastallaigor
changed the title
|
why not do the same thing for marimba? q2w3er5t6y7u and so on. |
|
Amazing man, thx! |
|
Sorry about the long wait! I'm doing some early spring cleaning and felt the need to finally address this Pull Request, which has accumulated a lot of merge conflicts over the years, primarily because of 101823e. That's my bad. This issue outlines a better solution as I don't want to move the bongo keys around anymore: #135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I did this only for fun. Accept this only if you really liked this feature, because I had to change some things a bid.
The major changes I did were for the keyboard in the computer could look like a piano keyboard (key positioning). To do that, I needed changed the keyboard keys for the Bongos and Cymbal mainly.
So now the new keys are:
Bongo left: -
Bongo right: =
Cymbal: *
Meow: Space (unchanged)
Piano: ZSXDCVGBHNJM,
Marimba: QW...P (unchanged)
Now "C" is the keyboard letter "Z", and "C#" is the keyboard letter "S", and so on, like a normal piano keyboard.
All the sounds were download at Freesound, so no copyright infringements here.
I also updated the instructions.