-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix loaders, remove unnecessary annoying effects, separate errors #226
Conversation
… fix "Load PDB data"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some in-line comments. Note also that yarn prettify did some work and yarn lint shows some warnings.
app/assets/javascripts/3dbio_viewer/src/data/repositories/AnnotationsExportApiRepository.ts
Outdated
Show resolved
Hide resolved
app/assets/javascripts/3dbio_viewer/src/data/repositories/BionotesPdbInfoRepository.ts
Outdated
Show resolved
Hide resolved
app/assets/javascripts/3dbio_viewer/src/data/repositories/BionotesPdbInfoRepository.ts
Outdated
Show resolved
Hide resolved
app/assets/javascripts/3dbio_viewer/src/data/repositories/BionotesPdbInfoRepository.ts
Outdated
Show resolved
Hide resolved
app/assets/javascripts/3dbio_viewer/src/data/repositories/BionotesPdbInfoRepository.ts
Outdated
Show resolved
Hide resolved
app/assets/javascripts/3dbio_viewer/src/data/repositories/protvista/ebi-pdbe-api.ts
Outdated
Show resolved
Hide resolved
app/assets/javascripts/3dbio_viewer/src/domain/entities/Protein.ts
Outdated
Show resolved
Hide resolved
...ts/javascripts/3dbio_viewer/src/webapp/components/molecular-structure/MolecularStructure.tsx
Outdated
Show resolved
Hide resolved
...ts/javascripts/3dbio_viewer/src/webapp/components/molecular-structure/MolecularStructure.tsx
Outdated
Show resolved
Hide resolved
Thanks @tokland for your review! The lint warnings actually are kinda intended, it's a task related to "go to top" button. Now is bugged, so I removed it, that's why lint marks as unused |
📌 References
📝 Implementation
Main changes:
Fixes:
🎨 Screenshots
🔥 Testing
Params to try all at once:
!6zow:B+EMD-11328|6aba+!6w9c
on init