Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loaders, remove unnecessary annoying effects, separate errors #226

Merged
merged 24 commits into from
Feb 12, 2024

Conversation

p3rcypj
Copy link

@p3rcypj p3rcypj commented Feb 5, 2024

📌 References

📝 Implementation

Main changes:

  • Separate the errors that are related to the viewer and those that are related to data.
  • Removed clipping
  • Fix MolecularStructure for undesired loads
  • Added toasts to pdbe-molstar
  • Decouple UniprotID

Fixes:

  • If main PDB is set hidden on URL params on init is not being applied on molstar (only on UI state)
  • If chain is added on URL params on init, highlight doesn't occur
  • Fix "Load PDB data" after any change on selection or visual change
  • When EMDB is set hidden, it shouldn't trigger new "Load PDB data"

🎨 Screenshots

image

🔥 Testing

Params to try all at once: !6zow:B+EMD-11328|6aba+!6w9c on init

@p3rcypj p3rcypj changed the title Fix loaders, and unnecessary annoying effects Fix loaders, remove unnecessary annoying effects, separate errors Feb 5, 2024
Copy link

@tokland tokland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some in-line comments. Note also that yarn prettify did some work and yarn lint shows some warnings.

@p3rcypj
Copy link
Author

p3rcypj commented Feb 7, 2024

Thanks @tokland for your review! The lint warnings actually are kinda intended, it's a task related to "go to top" button. Now is bugged, so I removed it, that's why lint marks as unused

@adrianq adrianq merged commit f80b12b into development Feb 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants