Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist currentModule context within page refresh #34

Merged
merged 2 commits into from
May 14, 2024

Conversation

davidbgomes
Copy link

📌 References

📝 Implementation

  • Use session storage to persist currentModule within page refreshes

📹 Screenshots/Screen capture

🔥 Notes to the tester

@davidbgomes
Copy link
Author

Thanks @9sneha-n , good points, addressed that.

@MiquelAdell MiquelAdell requested a review from xurxodev May 9, 2024 12:20
@9sneha-n
Copy link

9sneha-n commented May 9, 2024

@davidbgomes looks good to me. Lets ensure we have the code in the right layer by waiting for @xurxodev's review.

@MiquelAdell MiquelAdell merged commit f2118a7 into development May 14, 2024
1 check passed
@MiquelAdell MiquelAdell deleted the fix/current-module-context branch May 14, 2024 11:29
@9sneha-n
Copy link

@xurxodev The PR is merged , but please provide your review whenever possible and we will address it in a new PR.

Copy link

@xurxodev xurxodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@9sneha-n I've reviewed the code.

I understand the problem that to refresh the page the context of the current module is loss, and you use sessionStorage to persist it and to avoid it.

In this case for me also is a presentation concern because data layer doesn't know anything about this context.

Not for now, but if you start to use sessionStorage in different parts of the app, then I would create a wrapper for window.sessionStorage named uiCache or whatever to centralize future changes about cache in one unique point.

@9sneha-n
Copy link

oesn't know anything about

@xurxodev Thank you for the review. Noted, if we use the session storage further, will ensure that we create an abstraction. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants