Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc Fixes - Delete custom AST Guidelines, Fetch AST guidelines for Non-Admin users, Disallow creation of multiple facility forms in same OU. #39

Merged
merged 5 commits into from
May 14, 2024

Conversation

9sneha-n
Copy link

@9sneha-n 9sneha-n commented May 8, 2024

📌 References

📝 Implementation

  1. Delete custom AST Guidelines from datastore on deletion of prevalence survey form
  2. Fetch AST guidelines for facility forms for Non-Admin users
  3. Do not allow creation of multiple facility forms in same OU.

📹 Screenshots/Screen capture

Delete.custom.ast.guideline.mov
Non-Admin.AST.guidelines.fetch.mov
Screenshot 2024-05-08 at 10 32 02 AM

🔥 Notes to the tester

@9sneha-n 9sneha-n changed the title Misc Fixes - Misc Fixes - Delete custom AST Guidelines, Fetch AST guidelines for Non-Admin users, Disallow creation of multiple facility forms in same OU. May 8, 2024

return Future.success({
name: prevalenceSurveyName ?? "",
astGuidelineType: !customASTGuideline

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  astGuidelineType: !customASTGuideline
                               ? (astGuidelineType === "CLSI" || astGuidelineType === "EUCAST") ? astGuidelineType : undefined
                                : "CUSTOM",

Copy link

@anagperal anagperal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @9sneha-n ! Just a comment that it's not a blocking one (code-only review)

@MiquelAdell MiquelAdell merged commit cae7fe3 into development May 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants