add missing params for new tracker api #147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokland
reviewed
May 31, 2024
tokland
reviewed
Aug 6, 2024
src/api/trackerTrackedEntities.ts
Outdated
| | "updatedAt"; | ||
| }; | ||
|
|
||
| export type TrackedAttributesFields = { type: "id"; id: Id }; |
There was a problem hiding this comment.
Typically, TS uses singular names for this kind of types.
src/api/trackerTrackedEntities.ts
Outdated
| | "updatedAt"; | ||
| }; | ||
|
|
||
| export type TrackedAttributesFields = { type: "id"; id: Id }; |
There was a problem hiding this comment.
The name of type makes it clear within the module, but the plain object is created (example: { type: "id", id: "wMhqqPLb7pP", direction: "desc" }), we don't know what is the model of that id. Maybe type: "trackedEntityAttributeId"? (+ update README)
…e/tracker-missing-params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
/api/tracker/trackedEntities?order=[attribute_id]:descDocs
https://docs.dhis2.org/en/full/develop/dhis-core-version-240/developer-manual.html?#:~:text=Supported%20fields:
Tracked Entities with order param
https://play.im.dhis2.org/stable-2-40-3-1/api/tracker/trackedEntities.json?fields=trackedEntity,attributes&ouMode=ALL&program=IpHINAT79UW&order=w75KJ2mc4zz:desc
pageCountproperty for trackedEntities and eventsTracked Entities
https://play.im.dhis2.org/stable-2-40-3-1/api/tracker/trackedEntities.json?fields=trackedEntity,orgUnit&ouMode=ALL&program=IpHINAT79UW&totalPages=true
Events
https://play.im.dhis2.org/stable-2-40-3-1/api/tracker/events.json?fields=event,orgUnit&ouMode=ALL&program=IpHINAT79UW&totalPages=true