Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new script] events detect-external-orgunits #57

Draft
wants to merge 8 commits into
base: development
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,16 @@ Expected format of `xlsx` file:

## Events

### Detect events assigned to organisation units outside their enrollment

When enrollments are transferred to another org unit, the existing events keep their original org unit. While that's the expected default behaviour, sometimes we need to detect and fix these mismatches:

```shell
$ yarn start:dev events detect-orgunits-outside-enrollment \
--url "http://localhost:8080" --auth "USER:PASS" \
--notify-email="SUBJECT,EMAIL1,EMAIL2,..."
```

### Move events from one orgunit to another

Move events for program events (so no enrollments/TEIs move is supported):
Expand Down
10 changes: 6 additions & 4 deletions src/data/CategoryOptionD2Repository.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,26 +74,28 @@ export class CategoryOptionD2Repository implements CategoryOptionRepository {
{
recordsSkipped: saveResponse.status === "ERROR" ? catOptionsToSave.map(co => co.id) : [],
errorMessage,
created: saveResponse.response.stats.created,
ignored: saveResponse.response.stats.ignored,
updated: saveResponse.response.stats.updated,
...saveResponse.response.stats,
},
];
});

return stats.reduce(
(acum, stat) => {
(acum, stat): Stats => {
return {
recordsSkipped: [...acum.recordsSkipped, ...stat.recordsSkipped],
errorMessage: `${acum.errorMessage}${stat.errorMessage}`,
created: acum.created + stat.created,
ignored: acum.ignored + stat.ignored,
updated: acum.updated + stat.updated,
deleted: acum.deleted + stat.deleted,
total: acum.total + stat.total,
};
},
{
recordsSkipped: [],
errorMessage: "",
deleted: 0,
total: 0,
created: 0,
ignored: 0,
updated: 0,
Expand Down
84 changes: 55 additions & 29 deletions src/data/D2Tracker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,18 @@
import { Stats } from "domain/entities/Stats";
import { D2Api } from "types/d2-api";
import log from "utils/log";
import { TrackerPostRequest } from "@eyeseetea/d2-api/api/tracker";
import { TrackedEntitiesGetResponse } from "@eyeseetea/d2-api/api/trackerTrackedEntities";
import { TrackerEnrollmentsResponse } from "@eyeseetea/d2-api/api/trackerEnrollments";
import { TrackerEventsResponse } from "@eyeseetea/d2-api/api/trackerEvents";

export class D2Tracker {
constructor(private api: D2Api) {}

async postTracker(key: TrackerDataKey, objects: object[]): Async<TrackerResponse[]> {
async postTracker<Key extends TrackerDataKey>(
key: Key,
objects: Array<NonNullable<TrackerPostRequest[Key]>[number]>
): Async<TrackerResponse[]> {
const total = objects.length;
log.info(`Import data: ${key} - Total: ${total}`);
let page = 1;
Expand All @@ -29,17 +36,21 @@
return result;
}

private async postTrackerData(data: object, options: { payloadId: string }): Async<TrackerResponse> {
const response: TrackerResponse = await this.api
.post<TrackerResponse>("/tracker", { async: false }, data)
private async postTrackerData(
data: TrackerPostRequest,
options: { payloadId: string }
): Async<TrackerResponse> {
const response: TrackerResponse = await this.api.tracker
.post({ async: false }, data)
.getData()
.catch(err => {
if (err?.response?.data) {
return err.response.data as TrackerResponse;
.then(res => ({ ...res, stats: { ...Stats.empty(), ...res.stats } }))
.catch((err): TrackerResponse => {
const data = err?.response?.data;
if (data) {
return data;
} else {
return {
status: "ERROR",
typeReports: [],
stats: Stats.empty(),
};
}
Expand All @@ -56,37 +67,47 @@
}
}

async getFromTracker<T>(
apiPath: string,
async getFromTracker<Key extends TrackerDataKey>(
model: Key,
options: {
programIds: string[];
orgUnitIds: string[] | undefined;
fields?: string;
trackedEntity?: string | undefined;
}
): Promise<T[]> {
const output = [];
const { programIds, orgUnitIds, fields = "*", trackedEntity } = options;
): Promise<Array<Mapping[Key][number]>> {
type Output = Array<Mapping[Key][number]>;

const output: Output = [];
const { programIds, orgUnitIds, trackedEntity } = options;

for (const programId of programIds) {
let page = 1;
let dataRemaining = true;

while (dataRemaining) {
const pageSize = 1000;
log.debug(`GET ${apiPath} (pageSize=${pageSize}, page=${page})`);

const { instances } = await this.api
.get<{ instances: T[] }>(`/tracker/${apiPath}`, {
page,
pageSize: pageSize,
ouMode: orgUnitIds ? "SELECTED" : "ALL",
orgUnit: orgUnitIds?.join(";"),
fields: fields,
program: programId,
trackedEntity,
})
.getData();
log.debug(`GET ${model} (pageSize=${pageSize}, page=${page})`);

const apiOptions = {
page,
pageSize: pageSize,
ouMode: orgUnitIds ? ("SELECTED" as const) : ("ALL" as const),
orgUnit: orgUnitIds?.join(";"),
fields: { $all: true as const },
program: programId,
trackedEntity,
};

const { tracker } = this.api;

const endpoint = {
trackedEntities: () => tracker.trackedEntities.get(apiOptions),

Check failure on line 104 in src/data/D2Tracker.ts

View workflow job for this annotation

GitHub Actions / Unit tests

Argument of type '{ page: number; pageSize: number; ouMode: "ALL" | "SELECTED"; orgUnit: string | undefined; fields: { $all: true; }; program: string; trackedEntity: string | undefined; }' is not assignable to parameter of type 'TrackerTrackedEntitiesParams<{ $all: true; }>'.
enrollments: () => tracker.enrollments.get(apiOptions),

Check failure on line 105 in src/data/D2Tracker.ts

View workflow job for this annotation

GitHub Actions / Unit tests

Argument of type '{ page: number; pageSize: number; ouMode: "ALL" | "SELECTED"; orgUnit: string | undefined; fields: { $all: true; }; program: string; trackedEntity: string | undefined; }' is not assignable to parameter of type 'TrackerEnrollmentsParams<{ $all: true; }>'.
events: () => tracker.events.get(apiOptions),

Check failure on line 106 in src/data/D2Tracker.ts

View workflow job for this annotation

GitHub Actions / Unit tests

Argument of type '{ page: number; pageSize: number; ouMode: "ALL" | "SELECTED"; orgUnit: string | undefined; fields: { $all: true; }; program: string; trackedEntity: string | undefined; }' is not assignable to parameter of type 'EventsParams<{ $all: true; }>'.
};

const res = await endpoint[model]().getData();
const instances: Output = res.instances as Output;

if (instances.length === 0) {
dataRemaining = false;
Expand All @@ -96,16 +117,21 @@
}
}
}
log.info(`GET ${apiPath} -> Total: ${output.length}`);
log.info(`GET ${model} -> Total: ${output.length}`);

return output;
}
}

type TrackerResponse = {
status: string;
typeReports: object[];
stats: Stats;
};

type TrackerDataKey = "events" | "enrollments" | "trackedEntities";

type Mapping = {
trackedEntities: TrackedEntitiesGetResponse<{ $all: true }>["instances"];

Check failure on line 134 in src/data/D2Tracker.ts

View workflow job for this annotation

GitHub Actions / Unit tests

Type 'TrackedEntitiesGetResponse' is not generic.
enrollments: TrackerEnrollmentsResponse<{ $all: true }>["instances"];

Check failure on line 135 in src/data/D2Tracker.ts

View workflow job for this annotation

GitHub Actions / Unit tests

Type 'TrackerEnrollmentsResponse' is not generic.
events: TrackerEventsResponse<{ $all: true }>["instances"];

Check failure on line 136 in src/data/D2Tracker.ts

View workflow job for this annotation

GitHub Actions / Unit tests

Type 'TrackerEventsResponse' is not generic.
};
Loading