Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/working tests #61

Open
wants to merge 10 commits into
base: development
Choose a base branch
from
Open

Feature/working tests #61

wants to merge 10 commits into from

Conversation

idelcano
Copy link
Contributor

@idelcano idelcano commented Oct 18, 2024

📌 References

  • Issue: Closes

📝 Implementation

  • Add test to TwoFactorReportUseCase
  • Add test to UserPermissionUseCase

🔥 Notes for the reviewer

This pull request includes the necessary changes to run tests and the tests for the script that checks two-factor authentication.

Unfortunately, I can't get a working branch with the user-permissions test.
I have two problems to finish that branch:

  • We changed some logic, and we need to add minimal tests to ensure nothing is broken.
  • When I execute the tests one by one, they pass. However, when I run all the tests together, three of them fail (the mocks return different objects compared to when I run them separately, and I see it at the end of the time).

https://github.com/EyeSeeTea/d2-tools/tree/feature/add_test_cd

📹 Screenshots/Screen capture

Copy link

@xurxodev xurxodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @idelcano

It's pending the second script for when we have time

Copy link

@xurxodev xurxodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @idelcano

I've only realised code review from the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants