Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIP] Hide schedule event in timeline mode #173

Open
wants to merge 3 commits into
base: develop-spip
Choose a base branch
from

Conversation

xurxodev
Copy link

@xurxodev xurxodev commented Aug 21, 2024

📌 References

⚙️ branches

app:
Origin: ffeature-spip/hide_schedule_event_in_timeline_mode Target: develop-spip
dhis2-android-SDK:
Origin: develop-eyeseetea

🎩 What is the goal?

Only visible add new in time line mode

📝 How is it being implemented?

  • Hardcode to hide schedule in timeline mode

💥 How can it be tested?

The problem is that in group mode to show schedule event menu uses hideDueDate in program stage. But in timeline mode program stage is null because manage all events without program stage reference, in this case always is creating the menu.
I've removed the menu creation in this case

💾 Requires DB migration?

  • Nope, we can just merge this branch.
  • Yes, but we need to apply it before merging this branch.
  • Yes, it's already applied.

🎨 UI changes?

  • [] Nope, the UI remains as beautiful as it was before!
  • Yeap, here you have some screenshots-
    Screenshot_20240821_110936
    Screenshot_20240821_110954

@xurxodev xurxodev changed the title Feature spip/hide schedule event in timeline mode [SPIP] Hide schedule event in timeline mode Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants