Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Simprints] avoid cancel duplicates dialog on touch outside #184

Conversation

xurxodev
Copy link

@xurxodev xurxodev commented Oct 1, 2024

📌 References

⚙️ branches

app:
Origin: feature-simprints/avoid_cancel_dialog_on_touch_outside Target: develop-simprints
dhis2-android-SDK:
Origin: 148a1f72eb93b2382e26e83f340dd32620a66c4e

🎩 What is the goal?

Possible duplicates dialogue should not be dismissed when you tap outside it

📝 How is it being implemented?

  • configure it in the dialog

💥 How can it be tested?

💾 Requires DB migration?

  • Nope, we can just merge this branch.
  • Yes, but we need to apply it before merging this branch.
  • Yes, it's already applied.

🎨 UI changes?

  • Nope, the UI remains as beautiful as it was before!
  • Yeap, here you have some screenshots-

Copy link
Member

@ifoche ifoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blindly approving it without functional testing as it doesn't work for me the SID login

@ifoche ifoche merged commit f9e993b into develop-simprints Nov 4, 2024
@ifoche ifoche deleted the feature-simprints/avoid_cancel_dialog_on_touch_outside branch November 4, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants