Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use onChildrenLoaded props to filter orgUnits with coordinates #54

Merged
merged 4 commits into from
Nov 6, 2024
Merged

fix: use onChildrenLoaded props to filter orgUnits with coordinates #54

merged 4 commits into from
Nov 6, 2024

Conversation

delemaf
Copy link

@delemaf delemaf commented Aug 14, 2024

use default app namespace### 📌 References

📝 Implementation

⚠️ Require PR EyeSeeTea/d2-ui-components#241

  • OrgUnits with coordinate are not all fetched anymore but fetch on OrgUnitsSelector change
  • Filtering by geometry props if OrgUnitsSelector items have a checkbox

🎨 Screenshots

Screen.Recording.2024-08-14.at.12.18.28.mov

🔥 How to test it? (If there is any special consideration or the reviewer does not know how to test it)

📑 Others

@delemaf delemaf added the bug Something isn't working label Aug 14, 2024
@delemaf delemaf self-assigned this Aug 14, 2024
@ifoche
Copy link
Member

ifoche commented Aug 14, 2024

Task linked: CU-86957kfzj Filter out OU before asking for all points in "import rule"

tokland
tokland reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@tokland tokland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[code only review]

src/webapp/components/org-unit/WithCoordinatesOrgUnitsSelector.tsx Outdated Show resolved Hide resolved
@delemaf delemaf requested a review from tokland September 9, 2024 08:06
tokland
tokland approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@tokland tokland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[code only review]

@delemaf delemaf mentioned this pull request Sep 25, 2024
Closed
@MiquelAdell MiquelAdell merged commit 3cf610e into development Nov 6, 2024
@MiquelAdell MiquelAdell deleted the fix/org-units-selector-with-coordinates-optimisation branch November 6, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiquelAdell MiquelAdell MiquelAdell approved these changes

@tokland tokland tokland approved these changes

Assignees

@delemaf delemaf

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@delemaf @ifoche @tokland @MiquelAdell @xurxodev