Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HMIS Tally Sheets in React #14

Merged
merged 398 commits into from
Sep 18, 2024
Merged

HMIS Tally Sheets in React #14

merged 398 commits into from
Sep 18, 2024

Conversation

p3rcypj
Copy link

@p3rcypj p3rcypj commented Sep 2, 2024 •
edited
Loading

📌 References

📝 Implementation

  • Set up skeleton and add needed dependencies (xlsx-populate - eyeseetea fork)
  • Convert actual api requests made with Angular ($resource)
  • Create all use cases and needed (planificate)
  • Display dataset form
  • Config repository constants (administratorGroups) & admin logic
  • Get translations and i18n
  • Select all languages, select all datasets, update lang after checked
  • Clear form function
  • UI
  • OrgUnit Selector
  • Convert print logic & excel export
  • Implement settings
  • Testing and CI (partial)

🎨 Screenshots

image
image

tokland and others added 30 commits January 20, 2021 12:55
@tokland
Install jest-environment-jsdom-fourteen to avoid error on jest
0b4237a
@SferaDev
Remove linter props from tsconfig
9a54054
@adrianq
Merge pull request #29 from EyeSeeTea/feature/update-deps
b44a127 
[Feature] Updates from predictors-extended-app
@SferaDev
Update dependencies from predictor-extended
8e4d86e
@tokland
Remove xlsx-populate, move argparse to devDeps
f04433e
@tokland
Declare global window with feedbackDhis2
de83b7e
@tokland
Move package.json scripts after dependencies
c11a02f
@tokland
Minor code refactor for App/AppConfig
6d12a31
@adrianq
Merge pull request #42 from EyeSeeTea/feature/update-deps
ca11871 
Update dependencies from predictor-extended
@SferaDev
Update skeleton app
0490e1d
@SferaDev
Change console.logs
0f8cdc1
@SferaDev
Update app props
0bb641b
@SferaDev
Remove baseUrl dependency
e441d37
@tokland
Minor cosmetics
069d237
@tokland
Add default environment variables to .env + note in readme
13d5b1c
@tokland
Add a simple spec for cypress
5949d19
@tokland
Update README
45c1a31
@tokland
Update test
00961ec
@SferaDev
Move instance entity to data layer
538667c
@adrianq
Merge pull request #44 from EyeSeeTea/update/xmart2dhis
16f96e4 
Update skeleton from xMART2DHIS
@tokland
Refactor src/setupProxy to proxy dhis2 requests transparently
65af2fa
@tokland
Remove scripts/ from gitignore
0a0ecb2
@tokland
Refactor src/scripts to use cmd-ts and dhis2 connection
55e2c4b
@tokland
Add missing translations
f61fa18
@tokland
Add missing interpolation jsx
af79202
@tokland
Rename build command
9cc0c56
@tokland
Refactor cypress tests to use TS and remove old code
ef310f5
@tokland
Use React.memo for all components
d794dd6
@tokland
Remove babel test for process.env.CYPRESS_E2E, fixed in v7.6.0
ff7167a
@tokland
Add cypress new TS files
40e1558
tokland
tokland reviewed Sep 17, 2024
View reviewed changes
Copy link

@tokland tokland left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[code only review] I understand we are time-limited, but anyway, I am adding comments so we keep track of things. All comments are best-practices.

i18n/en.pot Outdated Show resolved Hide resolved
src/data/repositories/ConfigD2ConstantsRepository.ts Outdated Show resolved Hide resolved
src/data/repositories/ConfigD2ConstantsRepository.ts Outdated Show resolved Hide resolved
src/data/repositories/ConfigD2ConstantsRepository.ts Outdated Show resolved Hide resolved
src/data/repositories/ConfigD2ConstantsRepository.ts Outdated Show resolved Hide resolved
src/domain/entities/DataSet.ts Outdated Show resolved Hide resolved
src/domain/usecases/ExportDataSetsUseCase.ts Outdated Show resolved Hide resolved
src/domain/usecases/GetAllBasicDataSetsInfoUseCase.ts Outdated Show resolved Hide resolved
src/webapp/components/settings-dialog/SettingsDialog.tsx Outdated Show resolved Hide resolved
src/webapp/pages/landing/LandingPage.tsx Show resolved Hide resolved
tokland
tokland reviewed Sep 17, 2024
View reviewed changes
Copy link

@tokland tokland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[code only review]

src/domain/entities/Ref.ts Outdated Show resolved Hide resolved
src/data/repositories/UserD2Repository.ts Show resolved Hide resolved
src/domain/repositories/UserRepository.ts Outdated Show resolved Hide resolved
src/domain/usecases/GetAllBasicDataSetsInfoUseCase.ts Show resolved Hide resolved
src/domain/usecases/GetDataSetsByIdsUseCase.ts Outdated Show resolved Hide resolved
tokland
tokland approved these changes Sep 17, 2024
View reviewed changes
Copy link

@tokland tokland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[code-only review] 👍

@adrianq adrianq changed the base branch from skeleton-master5 to development September 18, 2024 09:27
@adrianq adrianq merged commit 9a753f4 into development Sep 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokland tokland tokland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@p3rcypj @tokland @adrianq @SferaDev @xurxodev @nshandra @MiquelAdell @mariaozamiz @eperedo @deeonwuli