Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix merge error and avoid gent in progress as sent #2307

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

idelcano
Copy link
Contributor

📌 References

🎩 What is the goal?

Fix strange survey
The survey with in progress status are shown in connect list.

📝 How is it being implemented?

The strange survey is a in progress survey.
Changed the ereferals query to show only the surveys with status: sent, sending, quarantine, conflict and complete.
Fixed a merge bug when reload the sent surveys too.

💥 How can it be tested?

I don't know how reply this bug.

Use case 1: The ereferrals tab doesn't have any survey in progress.

💾 Requires DB migration?

  • Nope, we can just merge this branch.
  • Yes, but we need to apply it before merging this branch.
  • Yes, it's already applied.

🎨 UI changes?

  • Nope, the UI remains as beautiful as it was before!
  • Yeap, here you have some screenshots-

Copy link
Contributor

@xurxodev xurxodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idelcano if we have not a way to reply the bug to can be tested, I can not approve this PR the release day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants