Feature: Performance overview table with indicator linked #15
Conversation
delemaf
changed the base branch from
development
to
feature/full-create-edit-event-form
…ithub.com:EyeSeeTea/zebra-dev into feature/performace-overview-table-link-indicators
|
|
||
| export type DiseaseTotalAttrs = DiseaseEntry | HazardEntry; | ||
|
|
||
| export class AnalyticsD2Repository implements AnalyticsRepository { |
There was a problem hiding this comment.
analytics, indicators etc are DHIS concepts. As per clean architecture the repository should only deal with domain entities. So you can you rename the class, file and functions to not have any references to DHIS concepts but instead refer to Zebra concepts - performance overview table, performance overview repository etc.
| import { FutureData } from "../../api-futures"; | ||
| import { DataStoreClient } from "../../DataStoreClient"; | ||
|
|
||
| export enum ProgramIndicatorsDatastoreKey { |
There was a problem hiding this comment.
again, the enums and types should not refer to DHIS concepts like ProgramIndicators, please rename.
| @@ -0,0 +1,221 @@ | |||
| export enum IndicatorsId { | |||
| suspectedDisease = "jLvbkuvPdZ6", | |||
There was a problem hiding this comment.
I am guessing that these will be fetched from datastore in upcoming PRs?
| (value: string) => | ||
| setOrder && | ||
| setOrder({ | ||
| name: value, |
There was a problem hiding this comment.
whenever your set of a react state depends on its previous state, you need to use an updater function. https://react.dev/reference/react/useState#updating-state-based-on-the-previous-state.
| useEffect(() => { | ||
| if (dataPerformanceOverview) { | ||
| setDataPerformanceOverview(newDataPerformanceOverview => | ||
| _(newDataPerformanceOverview) |
There was a problem hiding this comment.
whenever your set of a react state depends on its previous state, you need to use an updater function. https://react.dev/reference/react/useState#updating-state-based-on-the-previous-state. Then add dataPerformanceOverviewdata as a dependency to the useEffect
bhavananarayanan
deleted the
feature/performace-overview-table-link-indicators
branch
📌 References
📝 Implementation
Needs EyeSeeTea/d2-api#150 to be merged before (it fixes ts error)
📹 Screenshots/Screen capture
🔥 Notes to the tester