feature: 717 performance section #21
Open
+1,430
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delemaf
changed the base branch from
development
to
feature/performace-overview-table-link-indicators
9sneha-n
changed the base branch from
feature/performace-overview-table-link-indicators
to
feature/add-event-tracker-map-with-merge
anagperal
reviewed
Oct 3, 2024
| return apiToFuture( | ||
| this.api.analytics.get({ | ||
| dimension: [ | ||
| `dx:${INDICATORS_717_PERFORMANCE.map(({ id }) => id).join(";")}`, |
There was a problem hiding this comment.
In the future we can get these Program Indicators from DataStore like Maps.
anagperal
reviewed
Oct 3, 2024
| this.api.analytics.get({ | ||
| dimension: [ | ||
| `dx:${INDICATORS_717_PERFORMANCE.map(({ id }) => id).join(";")}`, | ||
| "pe:THIS_YEAR", |
There was a problem hiding this comment.
Period dimension has to be this year?
anagperal
reviewed
Oct 3, 2024
| const percent = percentObj ? percentObj.value : 0; | ||
| const count = countObj ? countObj.value : 0; | ||
|
|
||
| let color: "green" | "red" | "grey" | "normal" | undefined; |
There was a problem hiding this comment.
Maybe better to create a function to get the color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
📹 Screenshots/Screen capture
🔥 Notes to the tester