59 feature request option to submit a list of bitrates to corrupt on target segment #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the stream proxy filter to parse both individual bitrate values and arrays of bitrate values for filtering. - Modified the input type `br` in the filter function to accept: - `number`: Individual bitrate values. - `number[]`: Arrays of bitrate values. - `"*"`: A wildcard to match any bitrate. This enhancement allows more flexible filtering based on bitrate specifications.
Instead of converting it, we now just check if it's an array and then uses .includes()
friday
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Looks good to me. Not tested.
A small advice is that when you return in each condition, you don't need else: https://eslint.org/docs/latest/rules/no-else-return
(this is not important though)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the stream proxy filter to parse both individual bitrate values and arrays of bitrate values for filtering.
Modified the input type br in the filter function to accept:
number: Individual bitrate values.
number[]: Arrays of bitrate values.
"*": A wildcard to match any bitrate.
This enhancement allows more flexible filtering based on bitrate specifications.
New PR since I changed the function.