fix: ensure stsc sample description id isn't 0

prevents a panic
Eyevinn · Jan 15, 2025 · 0d3d1f7 · 0d3d1f7
1 parent 58448ee
commit 0d3d1f7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/mp4/stsc.go b/mp4/stsc.go
@@ -67,6 +67,9 @@ func DecodeStscSR(hdr BoxHeader, startPos uint64, sr bits.SliceReader) (Box, err
 		b.Entries[i].FirstSampleNr = accSampleNr
 
 		sdi := sr.ReadUint32()
+		if sdi == 0 {
+			return nil, fmt.Errorf("stsc sample description id is 0")
+		}
 		if i == 0 {
 			b.singleSampleDescriptionID = sdi
 		} else {

diff --git a/mp4/testdata/fuzz/FuzzDecodeBox/4e3e98fc202208ff b/mp4/testdata/fuzz/FuzzDecodeBox/4e3e98fc202208ff
@@ -0,0 +1,2 @@
+go test fuzz v1
+[]byte("\x00\x00\x00(stsc0000\x00\x00\x00\x0200000000\x00\x00\x00\x00000000000000")
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		go test fuzz v1
		[]byte("\x00\x00\x00(stsc0000\x00\x00\x00\x0200000000\x00\x00\x00\x00000000000000")