added SbgpBox, SgpdBox in RemoveEncryptionBoxes #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobbee
reviewed
Apr 13, 2025
There was a problem hiding this comment.
@iMro0t Thanks for the PR.
The same remarks as in #420 applies to this PR and the commit message.
An additional complication here is that extra lines where added without testing, so the average test coverage is decreasing. That is currently not accepted by the Github actions of the project.
The way to get beyond this is to either test these lines or add tests for some other lines in the project in order to maintain or increase the test coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.