Source management additional filtering #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwallberg
suggested changes
Aug 26, 2024
There was a problem hiding this comment.
When doing filtering we should only filter using the data we have, we shouldn't need to get part of the data from an different resource.
Instead of making a new API request to the backend we can add the missing data to the database. The Source type isn't static so we can add whatever we want to it. So basically syncInventory & the Source type should updated to populate the necessary value :) eg. ingest_type
birme
pushed a commit
that referenced
this pull request
Aug 29, 2024
…rfile Move ARG GUI_VERSION to the layer that uses it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds additional filtering to the source management list / inventory management list.
It allows the user to filter sources based on source type (SDI/HDMI, SRT and NDI).