Delete "dead" source from inventory #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birme
pushed a commit
that referenced
this pull request
Aug 30, 2024
chore: build and push image on release (#5)
bwallberg
reviewed
Aug 30, 2024
bwallberg
reviewed
Aug 30, 2024
bwallberg
reviewed
Aug 30, 2024
bwallberg
reviewed
Aug 30, 2024
bwallberg
reviewed
Aug 30, 2024
bwallberg
suggested changes
Aug 30, 2024
malmen237
changed the title
malmen237
changed the title
…ting sources from api
malmen237
force-pushed
the
feat/delete-source-from-inventory
branch
from
64a1b7c
to
29ef5ba
Compare
Saelmala
reviewed
Sep 5, 2024
LucasMaupin
reviewed
Sep 5, 2024
Saelmala
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do:
The API isn't making it possible to delete the sources that are no longer active. To make the source-list less cluttered the "dead" sources statuses gets updated to "purge", with a possibility to use this later if it becomes possible to delete the sources from the API.
There is two ways that a source becomes "purge":d, either by manually set bu the user in the inventory or by having the status "gone" for more than 30 days.
A source with status other than "gone" cannot be set to "purge" and if a source with status "purge" were to become active again it would have its status set to "new".
When a source is active and therefore not possible to remove:
When a source is in-active and removable: