forked from OwnZones/orchestration-gui
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create multiple multiview outputs per production #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary of comments from old PR:
|
…of multiview, and minor fixes
LucasMaupin
approved these changes
Sep 5, 2024
src/components/modal/configureOutputModal/ConfigureOutputModal.tsx
Outdated
Show resolved
Hide resolved
Saelmala
reviewed
Sep 5, 2024
Saelmala
reviewed
Sep 5, 2024
Saelmala
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, just left a couple minor comments about code clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
When setting up a production this allows for adding multiple multiviews to each production, for the possibility of having multiviews with different setups.
Layout
Added buttons to add and remove additional multiviewers, when only one multiview remains the button is removed.
When production is running, all multiviewers can be located in the control window to the right.
An easier way to start all multiviewers at once is to install mpv-player ("brew install mpv" on mac) and then run all srt-links in the command-line "mpv srt://0.0.0.0:1234 & mpv srt://0.0.0.0:2345 & mpv srt://0.0.0.0:3456"