Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create multiple multiview outputs per production #6

Merged
merged 16 commits into from
Sep 5, 2024

Conversation

malmen237
Copy link

@malmen237 malmen237 commented Sep 2, 2024

What does this do?

When setting up a production this allows for adding multiple multiviews to each production, for the possibility of having multiviews with different setups.

Layout

Added buttons to add and remove additional multiviewers, when only one multiview remains the button is removed.
Screenshot 2024-08-27 at 13 42 00

When production is running, all multiviewers can be located in the control window to the right.

An easier way to start all multiviewers at once is to install mpv-player ("brew install mpv" on mac) and then run all srt-links in the command-line "mpv srt://0.0.0.0:1234 & mpv srt://0.0.0.0:2345 & mpv srt://0.0.0.0:3456"
Screenshot 2024-09-04 at 16 38 56

@malmen237
Copy link
Author

malmen237 commented Sep 2, 2024

Summary of comments from old PR:

  • I'm guessing that multiple multiviews cannot use the same port. What happens now if you set the same port number on more than one?
  • Why should we restrict removal so that at least one multiview exists? Shouldn't it be possible to remove them all? Not possible atm, if desirable needs a larger restructure where multiview is not a mandatory-value.
  • Each run through of array does not connect to right id, therefor only first multiview works atm.
  • Add copy link to all multiviews.
  • Removing source from running production is causing error.
  • We probably want to modify the production settings model to say multiviews instead of multiview that should make it easier to support both the old and new data model as well.
  • Add clearer distinction between runtime and setup code. I've added where I've updated the code, but a larger work would need to be done for thinks to be made more clear.

@malmen237 malmen237 marked this pull request as ready for review September 4, 2024 14:37
Copy link

@Saelmala Saelmala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just left a couple minor comments about code clean up

@malmen237 malmen237 merged commit 50d8e97 into main Sep 5, 2024
4 checks passed
@malmen237 malmen237 deleted the feat/create_multiple_multiview_outputs branch November 7, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants