Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove sources from pipelines + syncInventory #80

Merged
merged 2 commits into from
Nov 7, 2024
Merged

fix: remove sources from pipelines + syncInventory #80

merged 2 commits into from
Nov 7, 2024

Conversation

Saelmala
Copy link

@Saelmala Saelmala commented Nov 6, 2024

This PR

  1. Fixes the issues with sources not being deleted from pipelines, both for inactive and inactive productions
  2. Updated syncInventory to newest version, due to problem with the production.sources getting the SourceWithId format instead of SourceReference type

@Saelmala Saelmala self-assigned this Nov 6, 2024
malmen237
malmen237 approved these changes Nov 7, 2024
View reviewed changes
Copy link

@malmen237 malmen237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Saelmala Saelmala merged commit 700aa86 into refactor/RIPPP Nov 7, 2024
4 checks passed
@malmen237 malmen237 deleted the fix-bug-remove-sources-from-pipelines branch November 7, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malmen237 malmen237 malmen237 approved these changes

@LucasMaupin LucasMaupin Awaiting requested review from LucasMaupin

Assignees

@Saelmala Saelmala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saelmala @malmen237