Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: New UI: bug sourceId not setting correctly #85

Merged
merged 2 commits into from
Nov 8, 2024
Merged

fix: New UI: bug sourceId not setting correctly #85

merged 2 commits into from
Nov 8, 2024

Conversation

Saelmala
Copy link

@Saelmala Saelmala commented Nov 7, 2024

This PR solves the issue of:

  1. The sourceId not being set correctly / at all for an inactive production. This led to all sourceIds being set to 0 which meant other pipeline sources where overrided and if you added latency/alignment settings to one, it updated the settings for the wrong source in the database.
  2. The config-button is only supposed to show if pipelines are selected. The check only checked if pipeline Ids were undefined, but now instead they were empty strings, so the button showed anyway.

@Saelmala Saelmala self-assigned this Nov 7, 2024
@Saelmala Saelmala changed the title fix: bug sourceId not setting correctly fix: New UI: bug sourceId not setting correctly Nov 7, 2024
malmen237
malmen237 approved these changes Nov 8, 2024
View reviewed changes
Copy link

@malmen237 malmen237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malmen237 malmen237 merged commit ba606a5 into refactor/RIPPP Nov 8, 2024
4 checks passed
@malmen237 malmen237 deleted the fix/sourceId-not-setting-correctly branch November 8, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malmen237 malmen237 malmen237 approved these changes

@LucasMaupin LucasMaupin Awaiting requested review from LucasMaupin

Assignees

@Saelmala Saelmala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saelmala @malmen237