Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problems with [email protected] #111

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Fix problems with [email protected] #111

merged 1 commit into from
Dec 15, 2021

Conversation

staszek998
Copy link
Contributor

The 4.0.0 release of the marked package contains a breaking change that - guess what - breaks the <VueSimpleMDE> component. The main change is that the marked package does NOT provide a default export anymore.

For more information please see the release notes for [email protected]. Also, you might be interested in a related pull request inside the SimpleMDE repo.

The 4.0.0 release of the `marked` package contains a breaking change
that - guess what - breaks the <VueSimpleMDE> component. The main change
is that the `marked` package does NOT provide a default export anymore.

For more information please see the [release notes for
`[email protected]`](https://github.com/markedjs/marked/releases/tag/v4.0.0).
Also, you might be interested in a [related pull request inside the
SimpleMDE repo](sparksuite/simplemde-markdown-editor#825).
@F-loat F-loat merged commit 8b61003 into F-loat:master Dec 15, 2021
@F-loat
Copy link
Owner

F-loat commented Dec 15, 2021

Thanks.

@staszek998 staszek998 deleted the bug/marked-4-breaking-changes branch December 15, 2021 10:57
@staszek998
Copy link
Contributor Author

Happy to help, @F-loat! I'm waiting for the v0.5.2 release 😉

@arcreative
Copy link

@F-loat seems to me that the unbounded dependency on simplemde could have similar issues? Can it be careted to ^1.11.2 before the next release?

@staszek998
Copy link
Contributor Author

@arcreative, you're probably right and careting simplemde to a strict version would be a good idea, but you have to know that the 1.11.2 release of the simplemde is burdened with the exactly same kind of bug as discussed here (see pull request #825 in the simplemde repo).

@F-loat
Copy link
Owner

F-loat commented Dec 17, 2021

You can use resolutions to solve problems before simplemde updated.

/* package.json */
{
  "resolutions": {
    "marked": "3.0.8"
  }
}

@staszek998
Copy link
Contributor Author

Thanks for the tip, @F-loat! 🙏🏻
I'll definitely give it a go! 🚀

@staszek998
Copy link
Contributor Author

I've implemented the proposed change into my codebase and it did the trick! 🥳
Thanks again, @F-loat!

@arcreative
Copy link

For whatever reason, resolutions weren't working for me with Yarn, but I just provided your latest commit ref on main for now and it's working fine :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants