Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to install the library as a CMake project #344

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

CharlesGueunet
Copy link
Contributor

(Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.)

What does this implement/fix? Explain your changes.

These changes add the cmake mechanism to install the project so it can be used in a find_package by other projects.

Any relevant logs, error output, etc?

There is one change in this MR which is just commenting some lines causing a linker error on recent clang compilers. The error is provided in comment

Where has this been tested?

Operating System: Gentoo Linux

I also used fespp to ensure this library is correctly installed.

Other comments:

This PR is related to another MR updating fespp to uses this library as expected (will be provided here when available).

@philippeVerney
Copy link
Member

Thanks a lot @CharlesGueunet
I try to look at it deeper next week and wil let you know.

@philippeVerney
Copy link
Member

philippeVerney commented Mar 15, 2024

@CharlesGueunet Would it be possible to target the dev branch instead of the master one?

@CharlesGueunet CharlesGueunet changed the base branch from master to dev March 15, 2024 12:27
@CharlesGueunet
Copy link
Contributor Author

@CharlesGueunet Would it be possible to target the dev branch instead of the master one?

Done

I try to look at it deeper next week and wil let you know.

Thank you

Copy link
Member

@philippeVerney philippeVerney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all this work.
Not sure to have enough CMAKE knowledge to deeply understand the proposed changes but hopefully my review should be a bit useful.
I have a commit to push/patch right after this review.

src/FesapiCppConfig.cmake.in Outdated Show resolved Hide resolved
test/resqml2_test/Streamlines.cpp Outdated Show resolved Hide resolved
src/FesapiCppConfig.cmake.in Outdated Show resolved Hide resolved
@philippeVerney
Copy link
Member

Here is a patch trying to resolve my comments above.
0001-Proposal-after-review.patch

I also rebased on origin/dev to check and it is fine.

@CharlesGueunet
Copy link
Contributor Author

Here is a patch trying to resolve my comments above. 0001-Proposal-after-review.patch

I have applied your changes and rebuild successfully on my side.

Best,
Charles

@philippeVerney philippeVerney merged commit aa5f398 into F2I-Consulting:dev Mar 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants