Issue.1111.master

[jgruber]

@richbrowne

What issues does this address?

Fixes #1111
...

What's this change do?

Adds the template stdeb.cfg file back and adds the build Dockerfile and script for Ubuntu LTS 16.04

Where should the reviewer start?

On a machine with git and docker properly install, from the repository directory run:

./f5-openstack-agent-dist/scripts/package_agent.sh "ubuntu" "14.04"
./f5-openstack-agent-dist/scripts/package_agent.sh "ubuntu" "16.04"

Any background context?

[richbrowne]

Do you need to include the stdeb.cfg and setup.cfg files? If not, I would remove them. The other stuff looks fine.

[jgruber]

On a clean clone of f5-openstack-agent in the 'mitaka' branch I get this:

$python ./f5-openstack-agent-dist/scripts/universal_truth.py 
Traceback (most recent call last):
  File "./f5-openstack-agent-dist/scripts/universal_truth.py", line 63, in <module>
    main()
  File "./f5-openstack-agent-dist/scripts/universal_truth.py", line 57, in main
    edit_setups(cfg)
  File "./f5-openstack-agent-dist/scripts/universal_truth.py", line 50, in edit_setups
    construct_setups._construct_cfgs_from_json(cfg)
  File "/tmp/f5-openstack-agent/f5-openstack-agent-dist/scripts/construct_setups.py", line 69, in _construct_cfgs_from_json
    _construct_file(rpm.setup, rpm.reqs, rpm.fmt, rpm.start)
  File "/tmp/f5-openstack-agent/f5-openstack-agent-dist/scripts/construct_setups.py", line 182, in _construct_file
    name = str(req.name)
AttributeError: Requirement instance has no attribute 'name'
An error occurred: Requirement instance has no attribute 'name'

An no deb_dist/stdeb.cfg is written.

Let me know what the proper 'build' process should look like and we can get rid of the setup files as long as they are written properly.

[jgruber]

The output of pip parse_request which is what is 'missing' the name attribute is a string:

Requirement.parse('f5-sdk==2.3.3')

[richbrowne]

John, what version of pip is in your system? Are you building in Linux? Maybe Ubuntu?

[jgruber]

Clean Ubuntu host build.. 16.04.3. I'll upgrade pip and let you know..

$ cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=16.04
DISTRIB_CODENAME=xenial
DISTRIB_DESCRIPTION="Ubuntu 16.04.3 LTS"

$ uname -a
Linux buildhost 4.4.0-75-generic #96-Ubuntu SMP Thu Apr 20 09:56:33 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

$ pip --version
pip 7.1.2 from /usr/lib/python2.7/dist-packages (python 2.7)

[richbrowne]

I ran this on an Ubuntu Xenial system with pip version 8.1 and MacOS with pip version 9.1 This script runs as a part of our travis build too on 14.04. I would definitely like to understand why this is failing for you. I might change my travis build to Xenial and see how that works.

On Fri, Dec 1, 2017 at 4:25 AM, John Gruber ***@***.***> wrote: Clean Ubuntu host build.. 16.04.3. I'll upgrade pip and let you know.. $ cat /etc/lsb-release DISTRIB_ID=Ubuntu DISTRIB_RELEASE=16.04 DISTRIB_CODENAME=xenial DISTRIB_DESCRIPTION="Ubuntu 16.04.3 LTS" $ uname -a Linux buildhost 4.4.0-75-generic #96 <#96>-Ubuntu SMP Thu Apr 20 09:56:33 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux $ pip --version pip 7.1.2 from /usr/lib/python2.7/dist-packages (python 2.7) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1113 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIVe0WLU26HotDah6poniXY8dewVP1OLks5s7-JDgaJpZM4Qvnbs> .

Here is the section of the .travis.yml file that is used to build packages: - python f5-openstack-agent-dist/scripts/universal_truth.py - echo "setup.cfg:" - cat setup.cfg - echo "stdeb.cfg:" - cat f5-openstack-agent-dist/deb_dist/stdeb.cfg - f5-openstack-agent-dist/scripts/package_agent.sh "redhat" "7" - f5-openstack-agent-dist/scripts/package_agent.sh "redhat" "6" - f5-openstack-agent-dist/scripts/package_agent.sh "ubuntu" "14.04" - sudo chown -R travis:travis ${DIST_REPO}/rpms/build - sudo chown -R travis:travis ${DIST_REPO}/deb_dist/*.deb - f5-openstack-agent-dist/scripts/test_install.sh "redhat" "7" ${PKG_RELEASE_EL7} - f5-openstack-agent-dist/scripts/test_install.sh "ubuntu" "14.04" ${PKG_RELEASE_1404} - ./docs/scripts/docker-docs.sh ./docs/scripts/test-docs.sh