Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search bar for coop leaderboard #3053

Merged
merged 6 commits into from
Nov 28, 2023

Conversation

Kimo-s
Copy link
Contributor

@Kimo-s Kimo-s commented Nov 21, 2023

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Merging #3053 (f0039b7) into develop (8ddd12c) will decrease coverage by 0.01%.
Report is 4 commits behind head on develop.
The diff coverage is 61.11%.

❗ Current head f0039b7 differs from pull request most recent head 0a68fbb. Consider uploading reports for the commit 0a68fbb to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3053      +/-   ##
=============================================
- Coverage      58.91%   58.90%   -0.01%     
- Complexity      4458     4461       +3     
=============================================
  Files            558      558              
  Lines          20156    20206      +50     
  Branches        1034     1035       +1     
=============================================
+ Hits           11874    11902      +28     
- Misses          7736     7755      +19     
- Partials         546      549       +3     
Files Coverage Δ
...java/com/faforever/client/coop/CoopController.java 55.26% <61.11%> (+0.44%) ⬆️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ddd12c...0a68fbb. Read the comment docs.

@Sheikah45 Sheikah45 force-pushed the feature/#2880-coop-tab-search branch from 0a68fbb to 3fbd3f3 Compare November 28, 2023 02:43
@Sheikah45 Sheikah45 merged commit 5d27bbb into FAForever:develop Nov 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants