Skip to content

Remove controller caching

This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/patch failed Nov 19, 2023 in 1s

52.90% of diff hit (target 59.28%)

View this Pull Request on Codecov

52.90% of diff hit (target 59.28%)

Annotations

Check warning on line 618 in src/main/java/com/faforever/client/chat/AbstractChatTabController.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/chat/AbstractChatTabController.java#L618 

Added line #L618 was not covered by tests

Check warning on line 190 in src/main/java/com/faforever/client/chat/ChannelTabController.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/chat/ChannelTabController.java#L184-L190 

Added lines #L184 - L190 were not covered by tests

Check warning on line 42 in src/main/java/com/faforever/client/chat/ChatChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/chat/ChatChannel.java#L42 

Added line #L42 was not covered by tests

Check warning on line 94 in src/main/java/com/faforever/client/chat/ChatChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/chat/ChatChannel.java#L94 

Added line #L94 was not covered by tests

Check warning on line 162 in src/main/java/com/faforever/client/chat/KittehChatService.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/chat/KittehChatService.java#L160-L162 

Added lines #L160 - L162 were not covered by tests

Check warning on line 215 in src/main/java/com/faforever/client/chat/KittehChatService.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/chat/KittehChatService.java#L212-L215 

Added lines #L212 - L215 were not covered by tests

Check warning on line 424 in src/main/java/com/faforever/client/chat/KittehChatService.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/chat/KittehChatService.java#L413-L424 

Added lines #L413 - L424 were not covered by tests

Check warning on line 438 in src/main/java/com/faforever/client/chat/KittehChatService.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/chat/KittehChatService.java#L427-L438 

Added lines #L427 - L438 were not covered by tests

Check warning on line 511 in src/main/java/com/faforever/client/chat/KittehChatService.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/chat/KittehChatService.java#L509-L511 

Added lines #L509 - L511 were not covered by tests

Check warning on line 554 in src/main/java/com/faforever/client/chat/KittehChatService.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/chat/KittehChatService.java#L554 

Added line #L554 was not covered by tests

Check warning on line 559 in src/main/java/com/faforever/client/chat/KittehChatService.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/chat/KittehChatService.java#L559 

Added line #L559 was not covered by tests

Check warning on line 26 in src/main/java/com/faforever/client/discord/DiscordEventHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/discord/DiscordEventHandler.java#L25-L26 

Added lines #L25 - L26 were not covered by tests

Check warning on line 28 in src/main/java/com/faforever/client/discord/DiscordEventHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/discord/DiscordEventHandler.java#L28 

Added line #L28 was not covered by tests

Check warning on line 45 in src/main/java/com/faforever/client/discord/DiscordEventHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/discord/DiscordEventHandler.java#L45 

Added line #L45 was not covered by tests

Check warning on line 55 in src/main/java/com/faforever/client/discord/DiscordEventHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/discord/DiscordEventHandler.java#L55 

Added line #L55 was not covered by tests

Check warning on line 28 in src/main/java/com/faforever/client/discord/JoinDiscordEventHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/discord/JoinDiscordEventHandler.java#L28 

Added line #L28 was not covered by tests

Check warning on line 30 in src/main/java/com/faforever/client/fa/relay/ice/IceAdapterCallbacks.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/fa/relay/ice/IceAdapterCallbacks.java#L30 

Added line #L30 was not covered by tests

Check warning on line 35 in src/main/java/com/faforever/client/fa/relay/ice/IceAdapterCallbacks.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/fa/relay/ice/IceAdapterCallbacks.java#L35 

Added line #L35 was not covered by tests

Check warning on line 131 in src/main/java/com/faforever/client/fa/relay/ice/IceAdapterImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/fa/relay/ice/IceAdapterImpl.java#L131 

Added line #L131 was not covered by tests

Check warning on line 175 in src/main/java/com/faforever/client/fa/relay/ice/IceAdapterImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/fa/relay/ice/IceAdapterImpl.java#L175 

Added line #L175 was not covered by tests

Check warning on line 3 in src/main/java/com/faforever/client/fa/relay/ice/event/IceAdapterStateChanged.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/fa/relay/ice/event/IceAdapterStateChanged.java#L3 

Added line #L3 was not covered by tests

Check warning on line 84 in src/main/java/com/faforever/client/fx/BrowserCallback.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/fx/BrowserCallback.java#L84 

Added line #L84 was not covered by tests

Check warning on line 164 in src/main/java/com/faforever/client/game/CustomGamesController.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/game/CustomGamesController.java#L164 

Added line #L164 was not covered by tests

Check warning on line 97 in src/main/java/com/faforever/client/game/GamePathHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/game/GamePathHandler.java#L97 

Added line #L97 was not covered by tests

Check warning on line 103 in src/main/java/com/faforever/client/game/GamePathHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/faforever/client/game/GamePathHandler.java#L103 

Added line #L103 was not covered by tests
View more details on Codecov