Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the SR's Iridium Rocket Pack to deal damage in an area of effect #6383

Merged
merged 5 commits into from
Nov 17, 2024

Conversation

Basilisk3
Copy link
Collaborator

@Basilisk3 Basilisk3 commented Jul 31, 2024

Description of the proposed changes

The SR has four air-to-ground weapons: two bolters, which are the more dominant weapons, and two rocket packs, which are often overlooked. In the current release, only the bolters have area of effect damage, the rocket packs have none at all.

From a design perspective, this is suboptimal since the rockets have a decently large explosion effect. The Renegade uses the same projectile with similar effects and has an area of effect radius of 3. It is also not intuitive, because it could be reasonably assumed that the rocket packs perform similarly to either the Renegade or the other air-to-ground weapons of the SR. Balance wise, it results in the rocket packs underperforming against smaller targets, such as Titans.

Soul Ripper: Experimental Gunship (URA0401):

  • Iridium Rocket Pack (x2):
    • DamageRadius: 0 --> 3
    • Damage: 190 --> 150
    • DPS: 285 --> 225

Additional context

Since this does increase the effectiveness of the rocket packs, their DPS is reduced.

Checklist

  • Changes are documented in the changelog for the next game version

@Basilisk3 Basilisk3 marked this pull request as draft July 31, 2024 21:55
@Basilisk3 Basilisk3 marked this pull request as ready for review August 1, 2024 21:41
@lolaenter
Copy link

dont lower his dps, wtf. sr is bad now will be worse then now, why dont you lower mass of harms now that it is usless

@Basilisk3
Copy link
Collaborator Author

Basilisk3 commented Aug 3, 2024

dont lower his dps, wtf. sr is bad now will be worse then now,

The SR is not bad, and this PR only changes its secondary guns, so the balance impact of this is minimal. Please take note of the addition of a damage radius.

why dont you lower mass of harms now that it is usless

HARMS are not useless, and this PR is not about changing them.

@lL1l1 lL1l1 added the area: balance related to units balance label Aug 22, 2024
@lL1l1
Copy link
Contributor

lL1l1 commented Aug 22, 2024

You could argue that the inaccurate and 0 damage radius weapon is meant to increase DPS against large targets like structures or experimentals, and giving it a splash radius would make it significantly better against small targets.

Old DPS vs small targets Old DPS vs large targets New DPS vs all targets
1858 2428 2308 (+24% small targets, -5% large targets)

@Basilisk3
Copy link
Collaborator Author

Your calculation assumes that the rockets cannot hit smaller targets at all, which I think is a bit unrealistic. To test this, I disabled the SR's main weaponry and left only its rockets enabled. The rockets are inaccurate but they managed to hit their target (a Titan) with a likelihood of around 33% to 50% without splash.

When adjusting for this, I arrived at these values:

Old DPS vs small targets (33% hit chance): Old DPS vs small targets (50% hit chance) New DPS vs all targets
2046 2143 2308 (+12.8% or +7.7% small targets)

The hit chance is closer to 33% than it is to 50%, so I think it's fair to assume that the DPS is roughly 11% higher against smaller targets and 5% lower against larger targets. I think this is reasonable, but if you disagree with this, I can still move the values around.

Copy link
Contributor

@clyfordv clyfordv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, changes are as advertised. Synergizes with: #6435

@Basilisk3
Copy link
Collaborator Author

Approved by the Balance Team.

@Basilisk3 Basilisk3 merged commit 4ad2373 into FAForever:develop Nov 17, 2024
5 checks passed
@Basilisk3 Basilisk3 deleted the SR_Iridium_aoe branch November 17, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: balance related to units balance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants