Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add game version guard in the regular lobby #6406

Merged
merged 7 commits into from
Aug 13, 2024

Conversation

Garanas
Copy link
Member

@Garanas Garanas commented Aug 10, 2024

Description of the proposed changes

First implementation of the feature to not only embed the current game version (and commit hash) into what we deploy, but to also act on it to try and prevent desyncs.

One issue that occurs often when a release happens is a large number of desyncs. With these changes we introduce a guard to try and prevent the dissatisfaction that can occur when a release happens.

Testing done on the proposed changes

You can have multiple instances of the game on a local machine and join the lobby through LAN/IP.

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

@Garanas
Copy link
Member Author

Garanas commented Aug 10, 2024

@4z0t would you be available to add a russian translation to the lobby message?

@4z0t
Copy link
Member

4z0t commented Aug 10, 2024

@Garanas added

@Garanas Garanas merged commit 6208f25 into develop Aug 13, 2024
5 checks passed
@Garanas Garanas deleted the feature/version-management-02 branch August 13, 2024 17:17
@Garanas Garanas added the area: lobby related to lobby: options, chat, etc label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: lobby related to lobby: options, chat, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants