Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an OnImpact error for CZAR depth charges #6430

Merged
merged 2 commits into from
Sep 21, 2024

Conversation

lL1l1
Copy link
Contributor

@lL1l1 lL1l1 commented Sep 4, 2024

Issue

The HasImpacted = true line was not added back in during the refactor in #4517.

Description of the proposed changes

Add back the line.

Testing done on the proposed changes

The CZAR no longer gives errors after hitting an underwater unit with the depth charges.

Checklist

  • Changes are documented in the changelog for the next game version

@lL1l1 lL1l1 added the area: sim Area that is affected by the Simulation of the Game label Sep 4, 2024
Copy link
Contributor

@BlackYps BlackYps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@lL1l1 lL1l1 merged commit 96358c4 into FAForever:develop Sep 21, 2024
5 checks passed
@lL1l1 lL1l1 deleted the Fix/depth-charge01-error branch January 19, 2025 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: sim Area that is affected by the Simulation of the Game type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants