Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the hotkey to kill all your units #6463

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

Garanas
Copy link
Member

@Garanas Garanas commented Sep 25, 2024

Description of the proposed changes

Removes the hotkey, UI and sim capabilities to kill all of your units at a click of a button. As requested by the moderators on Discord.

Testing done on the proposed changes

Ran the game and went on a rampage. All appears good.

Additional context

In addition, I've checked whether campaign/coop maps use this functionality and they do not.

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

@github-actions github-actions bot marked this pull request as draft September 25, 2024 16:59
@Garanas Garanas marked this pull request as ready for review September 25, 2024 17:02
@Garanas
Copy link
Member Author

Garanas commented Oct 4, 2024

@maudlin27 can you confirm that these changes are requested by the moderation team 😄 ?

@Garanas Garanas added the feature: hotkeys related to miscellaneous hotkeys label Oct 4, 2024
@magge-faf
Copy link

@Garanas I can confirm, the request is approved by the moderator team.

@Garanas Garanas merged commit 6f74c0a into develop Oct 7, 2024
5 checks passed
@Garanas Garanas deleted the feature/moderation/remove-kill-all branch October 7, 2024 18:14
lL1l1 pushed a commit to lL1l1/fa that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: hotkeys related to miscellaneous hotkeys
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants