Setup for support of generated changelogs #6473
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garanas
added
the
area: changelog management
|
@Zjonn An initial setup of how we'll apply your work in-game. Looking forward to implementing your workflow into the deployment workflows 😃 ! |
Garanas
commented
Oct 8, 2024
| if Changelog.OpenChangelog() then | ||
| Changelog.Changelog(GetFrame(0)) | ||
| -- ChangelogDialog, if necessary. | ||
| local changelogDialogManager = import("/lua/ui/lobby/changelog/changelogdialog.lua") |
There was a problem hiding this comment.
This seems silly but we do this to isolate the import so that the hot reload functionality behaves better. As in - that it doesn't try to reload everything that imports the changelog dialog module at the file scope 😄 .
Garanas
force-pushed
the
feature/changelog-generation-setup
branch
from
d96a38d to
76d40ab
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
Closes #6239.
Related to #6444 and #6472.
Reworks the changelog dialog module.
Lazy loading of changelog data
The changelogs are now lazy-loaded. In practice that means that changelogs are only loaded into memory if a user ends up clicking on a changelog in the changelog dialog. This matters because without this we'd load in about five megabytes worth of data just by clicking on the lobby.
Hot reload
Add additional debugging functionality that allows one to edit the changelog with hot reload-like functionality. This means you can open the dialog and as you make changes to the dialog file it will re-open immediately with your changes applied!
hot-reload-example.mp4
Works better than in .Net 8.0!
Testing done on the proposed changes
Opening and closing of the dialog in a harmonic manner.
Checklist