Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SACU Base Stat Changes #6488

Open
wants to merge 15 commits into
base: feature/SACU-Rebalance2
Choose a base branch
from

Conversation

MrRowey
Copy link
Member

@MrRowey MrRowey commented Oct 22, 2024

PR Overview

This PR re-introduces previously approved stat adjustments for balance changes. With the transition to new leadership, we are resubmitting these adjustments for review and approval.


Balance Adjustments

The following stat changes apply to each faction’s units, with percentage reductions shown for comparison:

# Aeon
- Health: 15000 → 11500 (-23%)
- Regen: 17 → 14 (-17%)
- Energy Cost: 27100 → 21450 (-21%)
- Mass Cost: 1950 → 1650 (-15%)
- Build Rate: 56 → 40 (-29%)
- Build Time: 14400 → 11500 (-20%)
- Damage: 300 → 100 (-66%)
- Range: 30 → 25 (-17%)

# UEF
- Health: 16000 → 13000 (-18%)
- Regen: 20 → 16 (-20%)
- Energy Cost: 25200 → 21450 (-15%)
- Build Rate: 56 → 40 (-29%)
- Build Time: 14400 → 11500 (-20%)
- Damage: 300 → 100 (-66%)

# Cybran
- Health: 19000 → 12500 (-34%)
- Regen: 25 → 21 (-16%)
- Energy Cost: 26400 → 21450 (-19%)
- Build Rate: 56 → 40 (-29%)
- Build Time: 14400 → 11500 (-20%)
- Damage: 300 → 100 (-66%)

# Sera
- Health: 15500 → 12000 (-23%)
- Regen: 15 → 12 (-20%)
- Energy Cost: 30200 → 21450 (-29%)
- Build Rate: 56 → 40 (-29%)
- Build Time: 14400 → 11500 (-20%)
- Damage: 300 → 100 (-66%)
- Energy Production: 300 → 100 (-66%)
- Mass Production: 3 → 1 (-66%)

Checklist

  • All changes are clearly annotated and include comments where useful.
  • Changelog documentation is updated for the next game version to reflect these adjustments.

MrRowey added 10 commits June 26, 2024 10:56
Requires before merging:

- [ ]  FAForever#6300
- [ ] Quantum Gate Changes
- [ ] UEF Enhancements Updates
- [ ] Aeon Enhancements Updates
- [ ] Cybran Enhancements Updates
- [ ] Seraphim Enhancements Updates

## Checklist
- [ ] Changes are annotated, including comments where useful
- [ ] Changes are documented in the changelog for the next game version
## Description of the proposed changes
This is slowly towards the SACU Rebalance the Balance team has been
trying for the last 3 years.

### Whats Changed
```
Aeon:
Health : 15000 > 11500
RegenRate : 17 > 14
BuildRate : 56 > 40
GunDamage : 300 > 100
GunRange: 30 > 25
```

```
UEF:
Health : 16000 > 13000
RegenRate : 20 > 16
BuildRate : 56 > 40
GunDamage : 300 > 100
```

```
Cybran:
Health : 19000 > 12500
RegenRate : 25 > 21
BuildRate : 56 > 40
GunDamage : 300 > 100
```

```
Seraphim:
Health : 15500 > 12000
RegenRate : 15 > 12
BuildRate : 56 > 40
GunDamage : 400 > 100
EnergyProd: 300 > 100
MassProd: 3 > 1
```

```
All:
MassCost: 1650 
EnergyCost: 21,450
BuildTime: 11500

Wrecks Spawn now spawn on seabed
```
## Damage
The damage reductions that the base SACU have received will be
redistributed to the enhancement.

## Checklist
- [x] Changes are documented in the changelog for the next game version
Health : `10000 > 7500` [-25%]
Build Cost : ` 30000 > 25500 (Energy) | 3000 > 2550 (Mass) `  [-15%]
Build Time: ` 4097 > 4100` [+0.06%]
Adjacency: `T2 Mass Fab: -0.0075 > -0.0125 | T3 Mass Fab: -0.0375 >
-0.2`

## Checklist
- [X] Changes are documented in the changelog for the next game version
@MrRowey MrRowey added area: balance related to units balance area: balance idea related to suggestions for unit balance labels Oct 22, 2024
@MrRowey MrRowey mentioned this pull request Oct 22, 2024
8 tasks
@RabidPope
Copy link
Contributor

If im not mistaken, looking at this along with the upgrade changes results in reduced dps. Is that intended?

@MrRowey
Copy link
Member Author

MrRowey commented Oct 24, 2024

If im not mistaken, looking at this along with the upgrade changes results in reduced DPS. Is that intended?

The base SACU is to have more minimal stats than the upgrade, which gives them the desired traffic. Enhancements are all still Subject to Change but this was previsouled what was accepted at the beginning of the year so just a new PR for it.

The BT will start discussing this actively once the backlog of Other balance-related PR is dealt with.

@MrRowey MrRowey marked this pull request as ready for review November 18, 2024 20:13
Copy link
Collaborator

@Rhaelya Rhaelya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stats are as agreed upon by the balance team. These changes are a first draft to be implemented into the respective mod for in game testing, they are not supposed to be merged into any main or beta release for now.

@MrRowey MrRowey mentioned this pull request Nov 18, 2024
6 tasks
@MrRowey MrRowey changed the base branch from develop to feature/SACU-Rebalance November 18, 2024 21:28
@MrRowey
Copy link
Member Author

MrRowey commented Nov 18, 2024

@lL1l1 this can be merged

@lL1l1 lL1l1 changed the title SACU Base Stat Chanages SACU Base Stat Changes Nov 20, 2024
@lL1l1
Copy link
Contributor

lL1l1 commented Nov 20, 2024

This PR doesn't include the changes themselves? They're from #6302 which already has a snippet in balance.6301.md.

@MrRowey
Copy link
Member Author

MrRowey commented Nov 21, 2024

Hmm something may have got mixed up then

@Garanas
Copy link
Member

Garanas commented Nov 21, 2024

Please do not merge this right now, wait a few days until after the release is stable. If I am not mistaken then @Rhaelya wants these changes on FAF Beta Balance, and not in the major release of tomorrow.

@lL1l1
Copy link
Contributor

lL1l1 commented Nov 21, 2024

This PR points at FAForever:feature/SACU-Rebalance

@Rhaelya
Copy link
Collaborator

Rhaelya commented Nov 21, 2024

Yes its not supposed to be in the major release, its supposed to be in a mod and possibly faf beta, only to be merged once the changes have been tested so perhaps earliest in the first release of 2025.

@Rhaelya
Copy link
Collaborator

Rhaelya commented Nov 21, 2024

Ive updated both my reviews on this and the #6489 to state they are not supposed to be merged currently.
Perhaps the "do not merge" tag could be applied to make sure?

@lL1l1
Copy link
Contributor

lL1l1 commented Nov 22, 2024

@MrRowey maybe its best to create a new branch and cherry pick the necessary commits there? This branch behaves badly on github desktop when I try to update it, and I end up using git gui.

@lL1l1
Copy link
Contributor

lL1l1 commented Nov 22, 2024

Ive updated both my reviews on this and the #6489 to state they are not supposed to be merged currently. Perhaps the "do not merge" tag could be applied to make sure?

At the top of the page it says

MrRowey wants to merge 6 commits into FAForever:feature/SACU-Rebalance from MrRowey:SCU-Base-Stats

it means that this is being merged into the feature/SACU-Rebalance branch. Faf develop and faf beta are automatically updated from the develop branch, so merging this PR won't affect what is deployed to faf develop or faf beta.
I think this branch is just being used to stack the various SACU PRs before they all get merged together into develop.

@MrRowey
Copy link
Member Author

MrRowey commented Nov 22, 2024

@lL1l1 yeh probs best to do a new branch. would you be able to create a new branch for me so I can change the PR merge too

@lL1l1
Copy link
Contributor

lL1l1 commented Nov 24, 2024

@MrRowey I have created the new branch: feature/SACU-Rebalance2

@MrRowey MrRowey changed the base branch from feature/SACU-Rebalance to feature/SACU-Rebalance2 November 24, 2024 18:32
@MrRowey
Copy link
Member Author

MrRowey commented Nov 24, 2024

@lL1l1 I've moved this to the new branch so can me merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: balance idea related to suggestions for unit balance area: balance related to units balance
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

5 participants